RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-19 Thread Yogesh Narayan Gaur
nel.org; > devicet...@vger.kernel.org; r...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; linux-arm-ker...@lists.infradead.org; > computersforpe...@gmail.com; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI > controller > &

RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-19 Thread Yogesh Narayan Gaur
nel.org; > devicet...@vger.kernel.org; r...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; linux-arm-ker...@lists.infradead.org; > computersforpe...@gmail.com; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI > controller > &

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Boris Brezillon
Hi Yogesh, On Tue, 18 Sep 2018 11:34:18 + Yogesh Narayan Gaur wrote: > > > > Do we really need all those macros for registers and modes, that > > aren't even used in the driver? I don't know what the common > > practice is, but to me it seems like removing all the unused macros > > would

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Boris Brezillon
Hi Yogesh, On Tue, 18 Sep 2018 11:34:18 + Yogesh Narayan Gaur wrote: > > > > Do we really need all those macros for registers and modes, that > > aren't even used in the driver? I don't know what the common > > practice is, but to me it seems like removing all the unused macros > > would

RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Yogesh Narayan Gaur
ernel.org; devicet...@vger.kernel.org > Cc: r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux- > arm-ker...@lists.infradead.org; computersforpe...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI > contr

RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Yogesh Narayan Gaur
ernel.org; devicet...@vger.kernel.org > Cc: r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux- > arm-ker...@lists.infradead.org; computersforpe...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI > contr

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Frieder Schrempf
Hi Yogesh, I have some remarks about your general approach that came to me when looking at the FSPI driver with the things at the back of my mind, that I've learned from working at the FSL QSPI driver. On 17.09.2018 11:48, Yogesh Gaur wrote: - Add a driver for NXP FlexSPI host controller

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Frieder Schrempf
Hi Yogesh, I have some remarks about your general approach that came to me when looking at the FSPI driver with the things at the back of my mind, that I've learned from working at the FSL QSPI driver. On 17.09.2018 11:48, Yogesh Gaur wrote: - Add a driver for NXP FlexSPI host controller

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Frieder Schrempf
Hi Boris, Yogesh, On 17.09.2018 13:37, Boris Brezillon wrote: Hi Yogesh, On Mon, 17 Sep 2018 15:18:26 +0530 Yogesh Gaur wrote: + + /* +* R/W functions for big- or little-endian registers: +* The FSPI controller's endianness is independent of +* the CPU core's

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Frieder Schrempf
Hi Boris, Yogesh, On 17.09.2018 13:37, Boris Brezillon wrote: Hi Yogesh, On Mon, 17 Sep 2018 15:18:26 +0530 Yogesh Gaur wrote: + + /* +* R/W functions for big- or little-endian registers: +* The FSPI controller's endianness is independent of +* the CPU core's

RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Yogesh Narayan Gaur
r.kernel.org; devicet...@vger.kernel.org; r...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; linux-arm- > ker...@lists.infradead.org; computersforpe...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI &

RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Yogesh Narayan Gaur
r.kernel.org; devicet...@vger.kernel.org; r...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; linux-arm- > ker...@lists.infradead.org; computersforpe...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI &

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-17 Thread Boris Brezillon
Hi Yogesh, On Mon, 17 Sep 2018 15:18:26 +0530 Yogesh Gaur wrote: > + > + /* > + * R/W functions for big- or little-endian registers: > + * The FSPI controller's endianness is independent of > + * the CPU core's endianness. So far, although the CPU > + * core is

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-17 Thread Boris Brezillon
Hi Yogesh, On Mon, 17 Sep 2018 15:18:26 +0530 Yogesh Gaur wrote: > + > + /* > + * R/W functions for big- or little-endian registers: > + * The FSPI controller's endianness is independent of > + * the CPU core's endianness. So far, although the CPU > + * core is