Re: [PATCH v2 13/17] IB/Verbs: Reform cma/ucma with management helpers

2015-04-09 Thread Michael Wang
On 04/08/2015 07:02 PM, Hefty, Sean wrote: [snip] >> >> The wrapper make sense, but do we have the guarantee that IBoE port won't >> be used for AF_IB address? I just can't locate the place we filtered it >> out... > > I can't think of a reason why IBoE wouldn't work with AF_IB, but I'm not sure

RE: [PATCH v2 13/17] IB/Verbs: Reform cma/ucma with management helpers

2015-04-08 Thread Hefty, Sean
> On 04/07/2015 11:36 PM, Hefty, Sean wrote: > >> diff --git a/drivers/infiniband/core/cma.c > b/drivers/infiniband/core/cma.c > >> index d8a8ea7..c23f483 100644 > >> --- a/drivers/infiniband/core/cma.c > >> +++ b/drivers/infiniband/core/cma.c > >> @@ -435,10 +435,10 @@ static int cma_resolve_ib_de

Re: [PATCH v2 13/17] IB/Verbs: Reform cma/ucma with management helpers

2015-04-08 Thread Michael Wang
Hi, Sean Thanks for the review :-) cma is the most tough part during reform, I really need some guide in here. On 04/07/2015 11:36 PM, Hefty, Sean wrote: >> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c >> index d8a8ea7..c23f483 100644 >> --- a/drivers/infiniband/cor

Re: [PATCH v2 13/17] IB/Verbs: Reform cma/ucma with management helpers

2015-04-08 Thread Michael Wang
On 04/07/2015 11:11 PM, Steve Wise wrote: [snip] >> @@ -1006,17 +997,14 @@ static void cma_leave_mc_groups(struct >> rdma_id_private *id_priv) >> mc = container_of(id_priv->mc_list.next, >>struct cma_multicast, list); >> list_del(&mc->list

RE: [PATCH v2 13/17] IB/Verbs: Reform cma/ucma with management helpers

2015-04-07 Thread Hefty, Sean
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > index d8a8ea7..c23f483 100644 > --- a/drivers/infiniband/core/cma.c > +++ b/drivers/infiniband/core/cma.c > @@ -435,10 +435,10 @@ static int cma_resolve_ib_dev(struct rdma_id_private > *id_priv) > pkey = ntohs(addr

RE: [PATCH v2 13/17] IB/Verbs: Reform cma/ucma with management helpers

2015-04-07 Thread Steve Wise
> -Original Message- > From: Michael Wang [mailto:yun.w...@profitbricks.com] > Sent: Tuesday, April 07, 2015 7:37 AM > To: Roland Dreier; Sean Hefty; linux-r...@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; > net...@vger.kernel.org > Cc: Hal Rosenstock; Tom