Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-02 Thread Borislav Petkov
On Thu, Dec 03, 2020 at 01:27:27AM +, Troy Lee wrote: > Hi Broislav and Andrew, > > I removed these exported function and submitted v3 PATCH. I saw that. A couple of comments: First of all, please do not top-post on a public mailing list. Secondly, Joel gave you Reviewed-by: and Acked-by:

RE: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-02 Thread Troy Lee
t; MACHINE SUPPORT ; open > list:EDAC-CORE > Subject: Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac > driver > > On Thu, Dec 03, 2020 at 01:32:44AM +1030, Andrew Jeffery wrote: > > On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote: > > > Hi Joel, > > > &

Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-02 Thread Borislav Petkov
On Thu, Dec 03, 2020 at 01:32:44AM +1030, Andrew Jeffery wrote: > On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote: > > Hi Joel, > > > > Thanks for the suggestion, I'll fix the review and create an new patch > > against > > latest Linux branch. Those exported function will be referenced in > >

Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-02 Thread Andrew Jeffery
On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote: > Hi Joel, > > Thanks for the suggestion, I'll fix the review and create an new patch > against > latest Linux branch. Those exported function will be referenced in > other driver yet > to be upstream, so should I move those exported functions

RE: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-02 Thread Troy Lee
ENED > DEVICE TREE BINDINGS ; moderated > list:ARM/ASPEED MACHINE SUPPORT ; > moderated list:ARM/ASPEED MACHINE SUPPORT > ; open list ; > open list:EDAC-CORE ; leet...@gmail.com; Ryan > Chen > Subject: Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac > drive

Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-01 Thread Joel Stanley
On Wed, 2 Dec 2020 at 06:37, Troy Lee wrote: > > Adding AST2400 and AST2600 edac driver support. > > Signed-off-by: Troy Lee > --- > Change since v1: > 1. Removing SoC specific code > 2. Changing numerical representation of memory sizing > --- > drivers/edac/Kconfig | 6 +-- >