RE: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

2016-06-03 Thread Pramod Kumar
talin.mari...@arm.com; will.dea...@arm.com; kis...@ti.com; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; bcm-kernel- > feedback-l...@broadcom.com; linux-kernel@vger.kernel.org; > net...@vger.kernel.org > Subject: Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux drive

Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

2016-06-01 Thread David Miller
From: Pramod Kumar Date: Tue, 31 May 2016 19:06:39 +0530 > +static int iproc_mdio_wait_for_idle(void __iomem *base, bool result) > +{ > + u32 val; > + unsigned int timeout = 1000; /* loop for 1s */ Please order your local variable declarations from longest to shortest line. > +static in