Hi,
On 9/21/20 8:23 PM, Limonciello, Mario wrote:
+
+ "integer"-type specific properties:
+
+ min_value: A file that can be read to obtain the lower
+ bound value of the
+
+ max_value: A file that can be read to obtain the uppe
>
> > +
> > + "integer"-type specific properties:
> > +
> > + min_value: A file that can be read to obtain the lower
> > + bound value of the
> > +
> > + max_value: A file that can be read to obtain the upper
> > + bound value of the
>
On Mon, Sep 21, 2020 at 2:38 PM Hans de Goede wrote:
> On 9/17/20 8:55 AM, Divya Bharathi wrote:
...
> Now I see that you try to correctly deal with strncpy-s nastiness
> everywhere, but please just don't use it all.
> Not using strncpy at all is much better.
>
> A lot of the strncpy usage is hi
On Mon, Sep 21, 2020 at 3:08 PM Andy Shevchenko
wrote:
> On Mon, Sep 21, 2020 at 2:38 PM Hans de Goede wrote:
> > On 9/17/20 8:55 AM, Divya Bharathi wrote:
>
> ...
>
> > Now I see that you try to correctly deal with strncpy-s nastiness
> > everywhere, but please just don't use it all.
> > Not usi
Hi,
Ok code review this time. Still mainly focussing on the overal
structure and not so much individual functions.
Note the code is starting to look good to me.
One general remark, now that we are keeping the 1 file per
type (int/enum/string) layout, there are quite a few files
in this driver.
Hi,
As usual, first a review of the userspace API.
Note the biggest pending issue with the userspace API is if
we are going to keep this under /sys/devices/platform/dell-wmi-sysman/
or if we are going to have it under:
/sys/class/firmware-attributes/dell-wmi-sysman/
That is still being discuss
Hi Divya,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.9-rc5 next-20200916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as do
7 matches
Mail list logo
