Hi Bart, Avri,
On Tue, 2020-07-14 at 21:00 -0700, Bart Van Assche wrote:
> On 2020-07-13 01:10, Avri Altman wrote:
> > Artificially injecting errors is a very common validation mechanism,
> > Provided that you are not breaking anything of the upper-layers,
> > Which I don't think you are doing.
>
On 2020-07-13 01:10, Avri Altman wrote:
> Artificially injecting errors is a very common validation mechanism,
> Provided that you are not breaking anything of the upper-layers,
> Which I don't think you are doing.
Hi Avri,
My concern is that the code that is being added in the abort handler
Hi Avri,
On Tue, 2020-07-14 at 09:29 +, Avri Altman wrote:
> > > > > > +cleanup:
> > > > > > + spin_lock_irqsave(host->host_lock, flags);
> > > > > > + if (!test_bit(tag, >outstanding_reqs)) {
> > > Is this needed? it was already checked in line 6439.
> > >
> >
> > I am worried
> > > > > +cleanup:
> > > > > + spin_lock_irqsave(host->host_lock, flags);
> > > > > + if (!test_bit(tag, >outstanding_reqs)) {
> > Is this needed? it was already checked in line 6439.
> >
>
> I am worried about the case that interrupt comes very lately.
scsi timeout is 30sec - do
Hi Avri,
Sorry for the late response.
On Sun, 2020-07-12 at 10:04 +, Avri Altman wrote:
>
> >
> > Hi Avri,
> >
> > On Thu, 2020-07-09 at 08:31 +, Avri Altman wrote:
> > > >
> > > > If somehow no interrupt notification is raised for a completed request
> > > > and its doorbell bit is
>
> Hi Bart and Avri,
>
> On Sun, 2020-07-12 at 18:39 -0700, Bart Van Assche wrote:
> > On 2020-07-06 06:21, Stanley Chu wrote:
> > > If somehow no interrupt notification is raised for a completed request
> > > and its doorbell bit is cleared by host, UFS driver needs to cleanup
> > > its
Hi Bart and Avri,
On Sun, 2020-07-12 at 18:39 -0700, Bart Van Assche wrote:
> On 2020-07-06 06:21, Stanley Chu wrote:
> > If somehow no interrupt notification is raised for a completed request
> > and its doorbell bit is cleared by host, UFS driver needs to cleanup
> > its outstanding bit in
On 2020-07-06 06:21, Stanley Chu wrote:
> If somehow no interrupt notification is raised for a completed request
> and its doorbell bit is cleared by host, UFS driver needs to cleanup
> its outstanding bit in ufshcd_abort().
How is it possible that no interrupt notification is raised for a
>
> Hi Avri,
>
> On Thu, 2020-07-09 at 08:31 +, Avri Altman wrote:
> > >
> > > If somehow no interrupt notification is raised for a completed request
> > > and its doorbell bit is cleared by host, UFS driver needs to cleanup
> > > its outstanding bit in ufshcd_abort().
> > Theoretically,
Hi Avri,
On Thu, 2020-07-09 at 08:31 +, Avri Altman wrote:
> >
> > If somehow no interrupt notification is raised for a completed request
> > and its doorbell bit is cleared by host, UFS driver needs to cleanup
> > its outstanding bit in ufshcd_abort().
> Theoretically, this case is already
>
> If somehow no interrupt notification is raised for a completed request
> and its doorbell bit is cleared by host, UFS driver needs to cleanup
> its outstanding bit in ufshcd_abort().
Theoretically, this case is already accounted for -
See line 6407: a proper error is issued and eventually
11 matches
Mail list logo
