Re: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-21 Thread Paul Kocialkowski
Hi, On Thu, 2019-02-21 at 09:30 +, Peter Chen wrote: > > > > Current code w/o your patch, it is possible both ci->phy and > > > ci->usb_phy are valid if the USB PHY is not at the device tree, but > > > generic PHY is > > at the device tree. > > > If you don't want to fix this issue with thi

RE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-21 Thread Peter Chen
> > Current code w/o your patch, it is possible both ci->phy and > > ci->usb_phy are valid if the USB PHY is not at the device tree, but generic > > PHY is > at the device tree. > > If you don't want to fix this issue with this patch, it is ok too. We could > > fix it later. > > I'm not sure I

Re: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-21 Thread Paul Kocialkowski
On Thu, 2019-02-21 at 08:37 +, Peter Chen wrote: > > > > If there is a generic PHY node under USB controller, and there is a > > > USB PHY at other sides, both ci->phy and ci->usb_phy are valid, I > > > original thought it is the problem you met. > > > > Right, this is not the problem we are

RE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-21 Thread Peter Chen
> > If there is a generic PHY node under USB controller, and there is a > > USB PHY at other sides, both ci->phy and ci->usb_phy are valid, I > > original thought it is the problem you met. > > Right, this is not the problem we are having. The problem is that legacy USB > PHYs > are not grabbed

Re: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-21 Thread Paul Kocialkowski
Hi, On Thu, 2019-02-21 at 03:29 +, Peter Chen wrote: > > > On Mon, 2019-02-18 at 03:04 +, Peter Chen wrote: > > > > According to the chipidea driver bindings, the USB PHY is specified via > > > > the > > "phys" > > > > phandle node. However, this only takes effect for USB PHYs that use

RE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-20 Thread Peter Chen
> > On Mon, 2019-02-18 at 03:04 +, Peter Chen wrote: > > > According to the chipidea driver bindings, the USB PHY is specified via > > > the > "phys" > > > phandle node. However, this only takes effect for USB PHYs that use > > > the common PHY framework. For legacy USB PHYs, a simple looku

Re: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-18 Thread Paul Kocialkowski
Hi, On Mon, 2019-02-18 at 03:04 +, Peter Chen wrote: > > According to the chipidea driver bindings, the USB PHY is specified via the > > "phys" > > phandle node. However, this only takes effect for USB PHYs that use the > > common > > PHY framework. For legacy USB PHYs, a simple lookup based

RE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-17 Thread Peter Chen
> According to the chipidea driver bindings, the USB PHY is specified via the > "phys" > phandle node. However, this only takes effect for USB PHYs that use the common > PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY > type is done instead. > > This does not play out w