Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-04-03 Thread Shawn Guo
On Wed, Mar 26, 2014 at 08:26:27AM +0100, Marek Vasut wrote: > > > I think we disconnected here, sorry. Why can you not use (i2c_imx->dma != > > > NULL) instead of (i2c_imx->use_dma == true) please ? > > > > But there are two judge conditions. But only the "i2c_imx->dma", but also > > whether "i2c

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-26 Thread Marek Vasut
On Wednesday, March 26, 2014 at 08:08:28 AM, Yao Yuan wrote: > On Wednesday, March 26, 2014 at 02:27:46 PM, Marek Vasut wrote: > > On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > > > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > > > On Wednesday, March 26, 2014

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-26 Thread Yao Yuan
On Wednesday, March 26, 2014 at 02:27:46 PM, Marek Vasut wrote: > On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > > On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: > > > > > > [...] > > > > > > > > > +

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-25 Thread Marek Vasut
On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: > > > > [...] > > > > > > > + i2c_imx->use_dma = false; > > > > > + } else if (i2c_imx_dm

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-25 Thread Yao Yuan
On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: > > [...] > > > > > + i2c_imx->use_dma = false; > > > > + } else if (i2c_imx_dma_request(i2c_imx, (dma_addr_t)phy_addr)) > { > > > > + d

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-25 Thread Marek Vasut
On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: [...] > > > + i2c_imx->use_dma = false; > > > + } else if (i2c_imx_dma_request(i2c_imx, (dma_addr_t)phy_addr)) { > > > + dev_info(&pdev->dev, > > > + "can't request dma chan, faild use dma.\n"); >

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-25 Thread Yao Yuan
On Sunday, March 23, 2014 @ 11:50:00 AM, Marek Vasut wrote: > On Thursday, March 13, 2014 at 02:47:56 AM, Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in > > dts node. > > > > Signed-off-by: Yu

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-22 Thread Marek Vasut
On Thursday, March 13, 2014 at 02:47:56 AM, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts > node. > > Signed-off-by: Yuan Yao > --- > drivers/i2c/busses/i2c-imx.c | 354 > +