Re: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Borislav Petkov
On Mon, Dec 03, 2012 at 09:13:49PM +, Ortiz, Lance E wrote: > This a fine idea. I'm thinking we might want to implement that in a > later patch since it is a bigger change and we still need to see about > adding additional strings. Yes, definitely in a later patch or more depending on how much

RE: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Ortiz, Lance E
> > Maybe we should ask Yanmin who added those strings in > 6c2b374d74857e892080ee726184ec1d15e7d4e4; CCed. > > Also, it would make a lot of sense to have those string definitions > at one place and then reuse them instead of define them again in the > tracepoint header and they get out of sync a

Re: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Borislav Petkov
On Mon, Dec 03, 2012 at 08:01:46PM +, Ortiz, Lance E wrote: > > > +#define correctable_error_string \ > > > + {BIT(0),"Receiver Error"}, \ > > > + {BIT(6),"Bad TLP"}, \ > > > + {BIT(7),"Bad DLLP"},\ > >

RE: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Ortiz, Lance E
> > +#define correctable_error_string \ > > + {BIT(0),"Receiver Error"}, \ > > + {BIT(6),"Bad TLP"}, \ > > + {BIT(7),"Bad DLLP"},\ > > + {BIT(8),"RELAY_NUM Rollover"}, \ > > + {

Re: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-01 Thread Mauro Carvalho Chehab
Cheers, Mauro On Sat, 1 Dec 2012, Borislav Petkov wrote: On Sat, Dec 01, 2012 at 09:36:14AM -0200, Mauro Carvalho Chehab wrote: Please don't call it as "ras.h". Call it, instead, ras_aer.h (or something similar) as, if we're moving the tracing back to include/trace/events/, the same should

Re: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-01 Thread Borislav Petkov
On Sat, Dec 01, 2012 at 09:36:14AM -0200, Mauro Carvalho Chehab wrote: > Please don't call it as "ras.h". Call it, instead, ras_aer.h > (or something similar) as, if we're moving the tracing back to > include/trace/events/, the same should happen for the memory error > events. As you can see yours

Re: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-01 Thread Mauro Carvalho Chehab
Em Fri, 30 Nov 2012 14:33:30 -0700 Lance Ortiz escreveu: > This header file will define a new trace event that will be triggered when > a AER event occurs. The following data will be provided to the trace > event. > > char * name - String containing the device path You renamed it to dev_name.

Re: [PATCH v3 1/3] aerdrv: Trace Event for AER

2012-12-01 Thread Borislav Petkov
On Fri, Nov 30, 2012 at 02:33:30PM -0700, Lance Ortiz wrote: > This header file will define a new trace event that will be triggered when > a AER event occurs. The following data will be provided to the trace > event. > > char * name - String containing the device path Can we explain that device