Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-10 Thread Tomasz Figa
Hi Kamil, Please see my comments inline. On Tuesday 05 of November 2013 17:13:19 Kamil Debski wrote: > Add a new driver for the Exynos USB PHY. The new driver uses the generic > PHY framework. The driver includes support for the Exynos 4x10 and 4x12 > SoC families. > > Signed-off-by: Kamil

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-10 Thread Tomasz Figa
Hi Kamil, Please see my comments inline. On Tuesday 05 of November 2013 17:13:19 Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi David, On Wednesday 06 of November 2013 13:03:45 David Laight wrote: > > > I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1] > > > and couldn't find that big a difference in register layout. Of course > > > there are a few changes in HSIC bit fields and PHYFSEL but that's

RE: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread David Laight
> > I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1] > > and couldn't find that big a difference in register layout. Of course > > there are a few changes in HSIC bit fields and PHYFSEL but that's only > > minimal and could well be handled in a single driver. > > > > [1] ->

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
On Wednesday 06 of November 2013 18:20:36 Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote: > > Hi Kishon > > > > On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: > >> Hi, > >> > >> On Tuesday 05 November 2013 09:43 PM, Kamil

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote: Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: > > Add a new driver for the Exynos USB PHY. The new driver uses the generic > > PHY framework. The driver includes support for the Exynos 4x10

RE: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kamil Debski
Hi, > From: Jingoo Han [mailto:jg1@samsung.com] > Sent: Wednesday, November 06, 2013 2:03 AM > > On Wednesday, November 06, 2013 1:13 AM, Kamil Debski wrote: > > > > Add a new driver for the Exynos USB PHY. The new driver uses the > > generic PHY framework. The driver includes support for

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park ---

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin

RE: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kamil Debski
Hi, From: Jingoo Han [mailto:jg1@samsung.com] Sent: Wednesday, November 06, 2013 2:03 AM On Wednesday, November 06, 2013 1:13 AM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote: Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
On Wednesday 06 of November 2013 18:20:36 Kishon Vijay Abraham I wrote: Hi, On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote: Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote:

RE: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread David Laight
I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1] and couldn't find that big a difference in register layout. Of course there are a few changes in HSIC bit fields and PHYFSEL but that's only minimal and could well be handled in a single driver. [1] -

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi David, On Wednesday 06 of November 2013 13:03:45 David Laight wrote: I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1] and couldn't find that big a difference in register layout. Of course there are a few changes in HSIC bit fields and PHYFSEL but that's only

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-05 Thread Jingoo Han
On Wednesday, November 06, 2013 1:13 AM, Kamil Debski wrote: > > Add a new driver for the Exynos USB PHY. The new driver uses the generic > PHY framework. The driver includes support for the Exynos 4x10 and 4x12 > SoC families. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park >

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-05 Thread Jingoo Han
On Wednesday, November 06, 2013 1:13 AM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: