Re: [PATCH v3 2/2] drivers: mux: Add Generic regmap bitfield-based multiplexer in mmio-mux

2019-02-25 Thread Peter Rosin
On 2019-02-24 09:27, Pankaj Bansal wrote: > Generic register bitfield-based multiplexer that controls the multiplexer > producer defined under a parent node. > The driver corresponding to parent node provides register read/write > capabilities. > > Signed-off-by: Pankaj Bansal > --- > > Notes: >

RE: [PATCH v3 2/2] drivers: mux: Add Generic regmap bitfield-based multiplexer in mmio-mux

2019-02-25 Thread Pankaj Bansal
Hi Peter, > -Original Message- > From: Peter Rosin [mailto:p...@axentia.se] > Sent: Monday, 25 February, 2019 08:14 PM > To: Pankaj Bansal ; Leo Li > Cc: linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 2/2] drivers: mux: Add Generic regmap bitfield-based > mu

Re: [PATCH v3 2/2] drivers: mux: Add Generic regmap bitfield-based multiplexer in mmio-mux

2019-02-26 Thread Peter Rosin
On 2019-02-26 07:08, Pankaj Bansal wrote: >>> + if (IS_ERR_OR_NULL(regmap)) { >>> + ret = PTR_ERR_OR_ZERO(regmap) ? PTR_ERR(regmap) : - >> ENODEV; >> >> The above is not correct, this should be better (untested): >> >> ret = PTR_ERR(regmap) ?: -ENODEV; > > Omitting the sec