RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Alan, Thanks for the review... > > In Zynq Case it supports two types of the readback (Configuration registers, > Configuration data(fpga image)) which may not be the same case for other > vendors. > > Since I need to support both the use cases I have differentiated them using >

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Alan, Thanks for the review... > > In Zynq Case it supports two types of the readback (Configuration registers, > Configuration data(fpga image)) which may not be the same case for other > vendors. > > Since I need to support both the use cases I have differentiated them using >

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

On Wed, Jul 25, 2018 at 4:12 AM, Appana Durga Kedareswara Rao wrote: > Hi Alan, > > Thanks for the review... > > >> > >> > >> >> > +static bool readback_type; >> >> > +module_param(readback_type, bool, 0644); >> >> > +MODULE_PARM_DESC(readback_type, >> >> > +

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

On Wed, Jul 25, 2018 at 4:12 AM, Appana Durga Kedareswara Rao wrote: > Hi Alan, > > Thanks for the review... > > >> > >> > >> >> > +static bool readback_type; >> >> > +module_param(readback_type, bool, 0644); >> >> > +MODULE_PARM_DESC(readback_type, >> >> > +

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Alan, Thanks for the review... > Another minor thing. > > > + > > > +/** > ** > > +/ > > Let's keep the coding style consistent by not having Sure will fix in v4... > '***' > > >

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Alan, Thanks for the review... > Another minor thing. > > > + > > > +/** > ** > > +/ > > Let's keep the coding style consistent by not having Sure will fix in v4... > '***' > > >

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Alan, Thanks for the review... > > > > > >> > +static bool readback_type; > >> > +module_param(readback_type, bool, 0644); > >> > +MODULE_PARM_DESC(readback_type, > >> > + "readback_type 0-configuration register read " > >> > + "1- configuration

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Alan, Thanks for the review... > > > > > >> > +static bool readback_type; > >> > +module_param(readback_type, bool, 0644); > >> > +MODULE_PARM_DESC(readback_type, > >> > + "readback_type 0-configuration register read " > >> > + "1- configuration

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

On Tue, Jul 24, 2018 at 9:17 AM, Appana Durga Kedareswara rao wrote: Hi Appana, Another minor thing. > + > +// Let's keep the coding style consistent by not having '***' > +/** > + * Also,

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

On Tue, Jul 24, 2018 at 9:17 AM, Appana Durga Kedareswara rao wrote: Hi Appana, Another minor thing. > + > +// Let's keep the coding style consistent by not having '***' > +/** > + * Also,

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

On Tue, Jul 24, 2018 at 1:31 PM, Appana Durga Kedareswara Rao wrote: > Hi Moritz, > > Thanks for the review... > > >> Can you please make the commit message such that you have full sentences? >> >> "Add support for readback of FPGA configuration data and registers" of >> example. > >

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

On Tue, Jul 24, 2018 at 1:31 PM, Appana Durga Kedareswara Rao wrote: > Hi Moritz, > > Thanks for the review... > > >> Can you please make the commit message such that you have full sentences? >> >> "Add support for readback of FPGA configuration data and registers" of >> example. > >

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Moritz, Thanks for the review... > Can you please make the commit message such that you have full sentences? > > "Add support for readback of FPGA configuration data and registers" of > example. Sure will fix in v4. > > > > > Usage: > > Readback of PL configuration registers >

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Moritz, Thanks for the review... > Can you please make the commit message such that you have full sentences? > > "Add support for readback of FPGA configuration data and registers" of > example. Sure will fix in v4. > > > > > Usage: > > Readback of PL configuration registers >

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Appana, On Tue, Jul 24, 2018 at 7:17 AM, Appana Durga Kedareswara rao wrote: > This patch does the below > --> Adds support for readback of pl configuration data > --> Adds support for readback of pl configuration registers Can you please make the commit message such that you have full

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Appana, On Tue, Jul 24, 2018 at 7:17 AM, Appana Durga Kedareswara rao wrote: > This patch does the below > --> Adds support for readback of pl configuration data > --> Adds support for readback of pl configuration registers Can you please make the commit message such that you have full