Re: [PATCH v3 3/3] cpuacct: split usage into user_usage and sys_usage

On Thu, Mar 17, 2016 at 12:19:44PM +0800, Zhao Lei wrote: > +static u64 __cpuusage_read(struct cgroup_subsys_state *css, > +enum cpuacct_usage_index index) > { > struct cpuacct *ca = css_ca(css); > u64 totalcpuusage = 0; > int i; > > for_each_prese

Re: [PATCH v3 3/3] cpuacct: split usage into user_usage and sys_usage

On Thu, Mar 17, 2016 at 05:42:48PM +0800, Zhao Lei wrote: > > Ok, so while looking over this, it mostly uses for_each_present_cpu(), > > which is already dubious, but then cpuacct_stats_show() uses > > for_each_online_cpu(). > > > > Why is this? Why not always for_each_possible_cpu()? > > > > Su

RE: [PATCH v3 3/3] cpuacct: split usage into user_usage and sys_usage

Hi, Peter Zijlstra > -Original Message- > From: Peter Zijlstra [mailto:pet...@infradead.org] > Sent: Thursday, March 17, 2016 4:40 PM > To: Zhao Lei > Cc: linux-kernel@vger.kernel.org; Tejun Heo ; Yang > Dongsheng > Subject: Re: [PATCH v3 3/3] cpuacct: split usag