Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-09-29 Thread Lee Jones
On Thu, 29 Sep 2016, Kraemer, Matthias (Ferchau; ADITG/SW1) wrote: > Hello Mika, > > In line 1239 you specify "struct pci_bus *bus = dev->bus;" > }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev) > } > break; > > + case INTEL_SPI_BXT: {

Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-09-29 Thread Lee Jones
On Thu, 29 Sep 2016, Kraemer, Matthias (Ferchau; ADITG/SW1) wrote: > Hello Mika, > > In line 1239 you specify "struct pci_bus *bus = dev->bus;" > }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev) > } > break; > > + case INTEL_SPI_BXT: {

Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-09-29 Thread Mika Westerberg
On Thu, Sep 29, 2016 at 01:19:30PM +, Kraemer, Matthias (Ferchau; ADITG/SW1) wrote: > Hello Mika, > > In line 1239 you specify "struct pci_bus *bus = dev->bus;" > }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev) > } > break; > > +

Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-09-29 Thread Mika Westerberg
On Thu, Sep 29, 2016 at 01:19:30PM +, Kraemer, Matthias (Ferchau; ADITG/SW1) wrote: > Hello Mika, > > In line 1239 you specify "struct pci_bus *bus = dev->bus;" > }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev) > } > break; > > +

RE: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-09-29 Thread Kraemer, Matthias (Ferchau; ADITG/SW1)
Hello Mika, In line 1239 you specify "struct pci_bus *bus = dev->bus;" }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev) } break; + case INTEL_SPI_BXT: { + unsigned int p2sb = PCI_DEVFN(13, 0); + unsigned

RE: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-09-29 Thread Kraemer, Matthias (Ferchau; ADITG/SW1)
Hello Mika, In line 1239 you specify "struct pci_bus *bus = dev->bus;" }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev) } break; + case INTEL_SPI_BXT: { + unsigned int p2sb = PCI_DEVFN(13, 0); + unsigned

Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-08-30 Thread Lee Jones
On Mon, 15 Aug 2016, Mika Westerberg wrote: > Intel Apollo Lake SoC exposes serial SPI flash through the LPC device. The > SPI flash host controller is not discoverable through PCI config cycles > because P2SB (function 0 of the device 13) is hidden by the BIOS. We unhide > the device briefly in

Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC

2016-08-30 Thread Lee Jones
On Mon, 15 Aug 2016, Mika Westerberg wrote: > Intel Apollo Lake SoC exposes serial SPI flash through the LPC device. The > SPI flash host controller is not discoverable through PCI config cycles > because P2SB (function 0 of the device 13) is hidden by the BIOS. We unhide > the device briefly in