Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-13 Thread Ulf Hansson
On Wed, 12 Jun 2019 at 15:58, Arend Van Spriel wrote: > > > On 6/12/2019 1:48 PM, Ulf Hansson wrote: > > On Wed, 12 Jun 2019 at 13:11, Arend Van Spriel > > wrote: > >> > >> On 6/12/2019 12:10 PM, Ulf Hansson wrote: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: > mmc_s

Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-12 Thread Arend Van Spriel
On 6/12/2019 1:48 PM, Ulf Hansson wrote: On Wed, 12 Jun 2019 at 13:11, Arend Van Spriel wrote: On 6/12/2019 12:10 PM, Ulf Hansson wrote: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: mmc_set_data_timeout(md, func->card); mmc_wait_for_req(func->card->host, mr); These ar

Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-12 Thread Ulf Hansson
On Wed, 12 Jun 2019 at 13:11, Arend Van Spriel wrote: > > On 6/12/2019 12:10 PM, Ulf Hansson wrote: > >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: > >>mmc_set_data_timeout(md, func->card); > >>mmc_wait_for_req(func->card->host, mr); > > These are not okay, none of these th

Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-12 Thread Arend Van Spriel
On 6/12/2019 12:10 PM, Ulf Hansson wrote: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: mmc_set_data_timeout(md, func->card); mmc_wait_for_req(func->card->host, mr); These are not okay, none of these things calls should really be done from an SDIO func driver. It tells me tha

Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-12 Thread Ulf Hansson
On Mon, 10 Jun 2019 at 18:50, Doug Anderson wrote: > > Hi, > > On Mon, Jun 10, 2019 at 1:56 AM Hunter, Adrian > wrote: > > > > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > > @@ -16,6 +16,7 @@ > > > #inclu

Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-11 Thread Adrian Hunter
On 10/06/19 7:50 PM, Doug Anderson wrote: > Hi, > > On Mon, Jun 10, 2019 at 1:56 AM Hunter, Adrian > wrote: >> >>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>> @@ -16,6 +16,7 @@ >>> #include >>> #include >

Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-10 Thread Doug Anderson
Hi, On Mon, Jun 10, 2019 at 1:56 AM Hunter, Adrian wrote: > > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > > @@ -16,6 +16,7 @@ > > #include > > #include > > #include > > +#include > > SDIO function drive

RE: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-10 Thread Hunter, Adrian
> -Original Message- > From: Douglas Anderson [mailto:diand...@chromium.org] > Sent: Saturday, June 8, 2019 1:37 AM > To: Ulf Hansson ; Kalle Valo > ; Hunter, Adrian ; Arend > van Spriel > Cc: brcm80211-dev-list@broadcom.com; linux- > rockc...@lists.infradead.org; Double Lo ; > brianno