RE: [PATCH v4] can: Convert to runtime_pm

2015-01-12 Thread Appana Durga Kedareswara Rao
inkmann; grant.lik...@linaro.org; > w...@grandegger.com; Michal Simek > Subject: Re: [PATCH v4] can: Convert to runtime_pm > > On 01/12/2015 02:49 PM, Appana Durga Kedareswara Rao wrote: > > Hi Marc, > > > >> -Original Message- > >> From: Marc Kleine-Budde [mai

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-12 Thread Marc Kleine-Budde
r.kernel.org; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org; Soren Brinkmann; grant.lik...@linaro.org; >> w...@grandegger.com; Michal Simek >> Subject: Re: [PATCH v4] can: Convert to runtime_pm >> >> On 01/12/2015 07:59 AM, Appana Durga Kedareswara Rao wrote

RE: [PATCH v4] can: Convert to runtime_pm

2015-01-12 Thread Appana Durga Kedareswara Rao
inkmann; grant.lik...@linaro.org; > w...@grandegger.com; Michal Simek > Subject: Re: [PATCH v4] can: Convert to runtime_pm > > On 01/12/2015 07:59 AM, Appana Durga Kedareswara Rao wrote: > > Hi Marc, > > > >> -Original Message- > >> From: Marc Kleine-Budde [mai

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-12 Thread Marc Kleine-Budde
r.kernel.org; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org; Soren Brinkmann; grant.lik...@linaro.org; >> w...@grandegger.com >> Subject: Re: [PATCH v4] can: Convert to runtime_pm >> >> On 01/11/2015 06:34 AM, Appana Durga Kedareswara Rao wrote: >> [...] &

RE: [PATCH v4] can: Convert to runtime_pm

2015-01-12 Thread Appana Durga Kedareswara Rao
inkmann; grant.lik...@linaro.org; > w...@grandegger.com > Subject: Re: [PATCH v4] can: Convert to runtime_pm > > On 01/11/2015 06:34 AM, Appana Durga Kedareswara Rao wrote: > [...] > >>> return ret; > >>> } > >>> > >>> priv->

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-11 Thread Marc Kleine-Budde
On 01/11/2015 06:34 AM, Appana Durga Kedareswara Rao wrote: [...] >>> return ret; >>> } >>> >>> priv->write_reg(priv, XCAN_MSR_OFFSET, 0); >>> priv->write_reg(priv, XCAN_SRR_OFFSET, XCAN_SRR_CEN_MASK); >>> >>> if (netif_running(ndev)) { >>> priv->can.state =

RE: [PATCH v4] can: Convert to runtime_pm

2015-01-10 Thread Appana Durga Kedareswara Rao
.kernel.org; linux- > ker...@vger.kernel.org; Appana Durga Kedareswara Rao; Soren Brinkmann > Subject: Re: [PATCH v4] can: Convert to runtime_pm > > On 12/23/2014 01:25 PM, Kedareswara rao Appana wrote: > > Instead of enabling/disabling clocks at several locations in the > >

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-07 Thread Marc Kleine-Budde
On 01/07/2015 05:32 PM, Sören Brinkmann wrote: > On Wed, 2015-01-07 at 05:30PM +0100, Marc Kleine-Budde wrote: >> On 01/07/2015 04:58 PM, Sören Brinkmann wrote: I think you have to convert the _remove() function, too. Have a look at the gpio-zynq.c driver: > static int zynq_gpio_

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-07 Thread Sören Brinkmann
On Wed, 2015-01-07 at 05:30PM +0100, Marc Kleine-Budde wrote: > On 01/07/2015 04:58 PM, Sören Brinkmann wrote: > >> I think you have to convert the _remove() function, too. Have a look at > >> the gpio-zynq.c driver: > >> > >>> static int zynq_gpio_remove(struct platform_device *pdev) > >>> { > >>>

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-07 Thread Marc Kleine-Budde
On 01/07/2015 04:58 PM, Sören Brinkmann wrote: >> I think you have to convert the _remove() function, too. Have a look at >> the gpio-zynq.c driver: >> >>> static int zynq_gpio_remove(struct platform_device *pdev) >>> { >>> struct zynq_gpio *gpio = platform_get_drvdata(pdev); >>> >>> pm_run

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-07 Thread Sören Brinkmann
On Wed, 2015-01-07 at 01:28PM +0100, Marc Kleine-Budde wrote: > On 12/23/2014 01:25 PM, Kedareswara rao Appana wrote: > > Instead of enabling/disabling clocks at several locations in the driver, > > use the runtime_pm framework. This consolidates the actions for > > runtime PM in the appropriate ca

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-07 Thread Marc Kleine-Budde
On 12/23/2014 01:25 PM, Kedareswara rao Appana wrote: > Instead of enabling/disabling clocks at several locations in the driver, > use the runtime_pm framework. This consolidates the actions for > runtime PM in the appropriate callbacks and makes the driver more > readable and mantainable. > > Sig

Re: [PATCH v4] can: Convert to runtime_pm

2015-01-06 Thread Marc Kleine-Budde
On 01/06/2015 07:23 AM, Appana Durga Kedareswara Rao wrote: > Hi Marc, > > Could you please provide your feedback on this patch ? > > @Soren : Will update the driver with your comments during next version of the > patch. Sure, I'll return from my season holidays and will be in the offi

RE: [PATCH v4] can: Convert to runtime_pm

2015-01-05 Thread Appana Durga Kedareswara Rao
4:13 AM To: Appana Durga Kedareswara Rao Cc: w...@grandegger.com; m...@pengutronix.de; Michal Simek; grant.lik...@linaro.org; linux-...@vger.kernel.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org; Appana Durga Kedareswara Rao Subject: Re: [PATCH v4] can: Convert to runtime_pm On Tue

Re: [PATCH v4] can: Convert to runtime_pm

2014-12-23 Thread Sören Brinkmann
On Tue, 2014-12-23 at 05:55PM +0530, Kedareswara rao Appana wrote: > Instead of enabling/disabling clocks at several locations in the driver, > use the runtime_pm framework. This consolidates the actions for > runtime PM in the appropriate callbacks and makes the driver more > readable and mantaina

RE: [PATCH v4] can: Convert to runtime_pm

2014-12-23 Thread Appana Durga Kedareswara Rao
Hi Marc, I tried by splitting the xcan_berr_counter to __xcan_berr_counter but still seeing the same crash as pointed by the Soren in the previous version of the patch. Updated the driver with the other review comments in this patch. Regards, Kedar. -Original Message- From: Kedareswara