RE: [PATCH v4] can: xilinx CAN controller support.

2014-02-28 Thread Appana Durga Kedareswara Rao
l.org > Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v4] can: xilinx CAN controller support. > > On 02/28/2014 02:07 PM, Appana Durga Kedareswara Rao wrote: > >>>> What hap

Re: [PATCH v4] can: xilinx CAN controller support.

2014-02-28 Thread Marc Kleine-Budde
grant.lik...@linaro.org; robh...@kernel.org; linux-...@vger.kernel.org >> Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- >> ker...@vger.kernel.org; devicet...@vger.kernel.org >> Subject: Re: [PATCH v4] can: xilinx CAN controller support. >> >>

Re: [PATCH v4] can: xilinx CAN controller support.

2014-02-28 Thread Marc Kleine-Budde
On 02/28/2014 02:07 PM, Appana Durga Kedareswara Rao wrote: What happens if the interrupt handler is delayed? For example in a RT enabled system the interrupt handler runs as a thread. There might be other threads with higher priority. The hardware will probably send all CAN fra

RE: [PATCH v4] can: xilinx CAN controller support.

2014-02-28 Thread Appana Durga Kedareswara Rao
l.org > Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v4] can: xilinx CAN controller support. > > On 02/28/2014 01:44 PM, Appana Durga Kedareswara Rao wrote: > > Hi Marc, > > >

Re: [PATCH v4] can: xilinx CAN controller support.

2014-02-28 Thread Marc Kleine-Budde
r.com; Michal Simek; >> grant.lik...@linaro.org; robh...@kernel.org; linux-...@vger.kernel.org >> Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- >> ker...@vger.kernel.org; devicet...@vger.kernel.org >> Subject: Re: [PATCH v4] can: xilinx CAN contr

RE: [PATCH v4] can: xilinx CAN controller support.

2014-02-28 Thread Appana Durga Kedareswara Rao
l.org > Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v4] can: xilinx CAN controller support. > > On 02/28/2014 06:50 AM, Appana Durga Kedareswara Rao wrote: > > Hi Marc, > > >

Re: [PATCH v4] can: xilinx CAN controller support.

2014-02-28 Thread Marc Kleine-Budde
r.com; Michal Simek; >> grant.lik...@linaro.org; robh...@kernel.org; linux-...@vger.kernel.org >> Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- >> ker...@vger.kernel.org; devicet...@vger.kernel.org >> Subject: Re: [PATCH v4] can: xilinx CAN contr

RE: [PATCH v4] can: xilinx CAN controller support.

2014-02-27 Thread Appana Durga Kedareswara Rao
l.org > Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v4] can: xilinx CAN controller support. > > On 02/26/2014 03:46 PM, Appana Durga Kedareswara Rao wrote: > > Hi Marc

Re: [PATCH v4] can: xilinx CAN controller support.

2014-02-26 Thread Marc Kleine-Budde
r.com; Michal Simek; >> grant.lik...@linaro.org; robh...@kernel.org; linux-...@vger.kernel.org >> Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- >> ker...@vger.kernel.org; devicet...@vger.kernel.org >> Subject: Re: [PATCH v4] can: xilinx CAN contr

RE: [PATCH v4] can: xilinx CAN controller support.

2014-02-26 Thread Appana Durga Kedareswara Rao
l.org > Cc: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v4] can: xilinx CAN controller support. > > On 02/26/2014 02:07 PM, Appana Durga Kedareswara Rao wrote: > >> This loop loo

Re: [PATCH v4] can: xilinx CAN controller support.

2014-02-26 Thread Marc Kleine-Budde
On 02/26/2014 02:07 PM, Appana Durga Kedareswara Rao wrote: >> This loop looks broken. Can you explain how it works. >> >> What it shoud do is: >> We have put (priv->tx_head - priv->tx_tail) CAN frames into the FIFO. >> This means at maximum there could be this amount of CAN frames which >> have be

Re: [PATCH v4] can: xilinx CAN controller support.

2014-02-25 Thread Marc Kleine-Budde
On 02/24/2014 05:25 AM, Kedareswara rao Appana wrote: > This patch adds xilinx CAN controller support. > This driver supports both ZYNQ CANPS and Soft IP > AXI CAN controller. > > Signed-off-by: Kedareswara rao Appana Looks quite good. Just the tx_complete routine is a bit fishy. Comments inline