Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread Jonathan Cameron
On 1 March 2016 16:02:00 GMT+00:00, Michael Welling wrote: >On Tue, Mar 01, 2016 at 08:35:01AM +, ji...@jic23.retrosnub.co.uk >wrote: >> On 01.03.2016 02:42, Michael Welling wrote: >> >On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: >> >>On Mon, Feb 29, 2016 at 9:50 PM, Mich

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread Michael Welling
On Tue, Mar 01, 2016 at 08:35:01AM +, ji...@jic23.retrosnub.co.uk wrote: > On 01.03.2016 02:42, Michael Welling wrote: > >On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > >>On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling > >>wrote: > >>> On Fri, Feb 05, 2016 at 03:17:18PM +0

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread Michael Welling
On Tue, Mar 01, 2016 at 01:28:26PM +0200, Daniel Baluta wrote: > On Tue, Mar 1, 2016 at 4:42 AM, Michael Welling wrote: > > On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > >> On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > >> > On Fri, Feb 05, 2016 at 03:17:18PM +0200

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread Daniel Baluta
On Tue, Mar 1, 2016 at 4:42 AM, Michael Welling wrote: > On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: >> On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: >> > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: >> >> The driver has sysfs readings with runtime

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread jic23
On 01.03.2016 02:42, Michael Welling wrote: On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for pow

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >> It also offers buffer supp

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >> It also offers buffer supp

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >> It also offers buffer supp

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Lucas De Marchi
On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with IIO software >> triggers. >> > > Danie

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > The driver has sysfs readings with runtime PM support for power saving. > It also offers buffer support that can be used together with IIO software > triggers. > Daniel, So I noticed something yesterday while testing new boards. The

RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-18 Thread Sricharan
Hi, > On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote: > > On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote: > > > > Hi Sricharan, > > > > > > > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm- > pca9685.c > > > > right? > > > > > > > Yes. > > > > > > > I'm aski

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-17 Thread Michael Welling
On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote: > On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote: > > > Hi Sricharan, > > > > > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c > > > right? > > > > > Yes. > > > > > I'm asking this because this driv

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-10 Thread Michael Welling
On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote: > > Hi Sricharan, > > > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c > > right? > > > Yes. > > > I'm asking this because this driver doesn't seem to support runtime pm and > > there is no check for regmap_write/re

RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-10 Thread Sricharan
... > >> > > > > > >> > > > > Indeed it is the pm_runtime_get_sync that fails with a -EINVAL. > >> > > > > > >> > > > > > > > >> > > > > > > When I comment out the break the readings come back but > >> > > > > > > are not > >> > > updated continually. > >> > > > > > > If I read in_voltage0-voltage

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-10 Thread Daniel Baluta
>> > > > > > >> +static int ads1015_read_raw(struct iio_dev *indio_dev, >> > > > > > >> + struct iio_chan_spec const *chan, >> > > > > > >> +int >> > *val, >> > > > > > >> + int *val2, long mask) { >> > > > > > >> + int ret, idx; >> > > > > > >>

RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-10 Thread Sricharan
usen; Peter Meerwald-Stadler; Linux Kernel Mailing List; > > linux-...@vger.kernel.org; > > > Lucas De Marchi; Andy Gross; Pramod Gurav; Bjorn Andersson; Guenter > > > Roeck; eib...@gdsys.de; Sricharan R; linux-arm-...@vger.kernel.org > > > Subject: Re: [PATCH

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
On Mon, Feb 08, 2016 at 09:00:27PM +0100, Wolfram Sang wrote: > > > > On Mon, Feb 08, 2016 at 11:25:00AM +0100, Wolfram Sang wrote: > > > > > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > > > > > > On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > > > > > > > >>

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Wolfram Sang
> > > On Mon, Feb 08, 2016 at 11:25:00AM +0100, Wolfram Sang wrote: > > > > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > > > > > On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > > > > > > >> +static int ads1015_read_raw(struct iio_dev *indio_dev, > > > > > > >>

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
ux-arm-...@vger.kernel.org > > Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support > > > > On Mon, Feb 08, 2016 at 11:25:00AM +0100, Wolfram Sang wrote: > > > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > > > > On Fri, F

RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Sricharan
Stadler; Linux Kernel Mailing List; linux-...@vger.kernel.org; > Lucas De Marchi; Andy Gross; Pramod Gurav; Bjorn Andersson; Guenter > Roeck; eib...@gdsys.de; Sricharan R; linux-arm-...@vger.kernel.org > Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support > > On M

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
On Mon, Feb 08, 2016 at 04:44:02PM +0200, Daniel Baluta wrote: > On Mon, Feb 8, 2016 at 12:25 PM, Wolfram Sang wrote: > > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > >> On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > >> > >> +static int ads1015_read_raw(stru

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
On Mon, Feb 08, 2016 at 11:25:00AM +0100, Wolfram Sang wrote: > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > > > >> +static int ads1015_read_raw(struct iio_dev *indio_dev, > > > >> + str

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Daniel Baluta
On Mon, Feb 8, 2016 at 4:44 PM, Daniel Baluta wrote: > On Mon, Feb 8, 2016 at 12:25 PM, Wolfram Sang wrote: >> On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: >>> On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: >>> > >> +static int ads1015_read_raw(struct iio_dev *

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Daniel Baluta
On Mon, Feb 8, 2016 at 12:25 PM, Wolfram Sang wrote: > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: >> On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: >> > >> +static int ads1015_read_raw(struct iio_dev *indio_dev, >> > >> + struct iio_cha

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Wolfram Sang
On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > > >> +static int ads1015_read_raw(struct iio_dev *indio_dev, > > >> + struct iio_chan_spec const *chan, int *val, > > >> +

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-06 Thread Jonathan Cameron
On 06/02/16 11:05, Jonathan Cameron wrote: > On 05/02/16 13:17, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with IIO software >> triggers. >> >> Datasheet can be found here: >> http:/

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-06 Thread Jonathan Cameron
On 05/02/16 13:17, Daniel Baluta wrote: > The driver has sysfs readings with runtime PM support for power saving. > It also offers buffer support that can be used together with IIO software > triggers. > > Datasheet can be found here: > http://www.ti.com.cn/cn/lit/ds/symlink/ads1015.pdf > >

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-06 Thread Jonathan Cameron
On 05/02/16 21:44, Daniel Baluta wrote: > On Fri, Feb 5, 2016 at 11:02 PM, Lucas De Marchi > wrote: >> Hi Daniel, >> >> On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta >> wrote: >>> + >>> +static const struct i2c_device_id ads1015_id[] = { >>> + {"ads1015", 0}, >>> + {} >>> +}; >> >>

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Michael Welling
On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > >> +static int ads1015_read_raw(struct iio_dev *indio_dev, > >> + struct iio_chan_spec const *chan, int *val, > >> + int *val2, long mask) > >> +{ > >> + int ret, idx; > >> + str

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Daniel Baluta
On Fri, Feb 5, 2016 at 11:02 PM, Lucas De Marchi wrote: > Hi Daniel, > > On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta > wrote: >> + >> +static const struct i2c_device_id ads1015_id[] = { >> + {"ads1015", 0}, >> + {} >> +}; > > Since this module is not 100% compatible with the hwmon

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Lucas De Marchi
Hi Daniel, On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta wrote: > + > +static const struct i2c_device_id ads1015_id[] = { > + {"ads1015", 0}, > + {} > +}; Since this module is not 100% compatible with the hwmon version, wouldn't it be better to use another id? Other than that, I te

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Michael Welling
On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > On Fri, Feb 5, 2016 at 7:25 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >> It also offers buffer support

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Daniel Baluta
On Fri, Feb 5, 2016 at 7:25 PM, Michael Welling wrote: > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with IIO software >> triggers. >> >> Datashe

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Michael Welling
On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > The driver has sysfs readings with runtime PM support for power saving. > It also offers buffer support that can be used together with IIO software > triggers. > > Datasheet can be found here: > http://www.ti.com.cn/cn/lit/ds/s