Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-10 Thread Lee Jones
On Tue, 09 Mar 2021, Adam Ward wrote: > Hi Lee, > > Tidy, but I've noticed the logic got inverted along the way: > > > On Tue 09 Mar 2021, Lee Jones wrote: > > On Tue, 09 Mar 2021, Mark Jonas wrote: > > This is my suggestion: > > > > /* If SMBus Mode is not available, enter Two-Wire Mode

RE: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-09 Thread Adam Ward
Hi Lee, Tidy, but I've noticed the logic got inverted along the way: > On Tue 09 Mar 2021, Lee Jones wrote: > On Tue, 09 Mar 2021, Mark Jonas wrote: > This is my suggestion: > > /* If SMBus Mode is not available, enter Two-Wire Mode */ > if (!i2c_check_functionality(i2c->adapter,

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-09 Thread Lee Jones
On Tue, 09 Mar 2021, Mark Jonas wrote: > Hi Lee, > > Thank you for having a look at the patch. > > > > From: Hubert Streidl > > > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > > means the PMIC will automatically reset the interface when the clock > > > signal

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-09 Thread Mark Jonas
Hi Lee, Thank you for having a look at the patch. > > From: Hubert Streidl > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > means the PMIC will automatically reset the interface when the clock > > signal ceases for more than the SMBus timeout of 35 ms. > > > > If

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-08 Thread Lee Jones
On Mon, 08 Feb 2021, Mark Jonas wrote: > From: Hubert Streidl > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > means the PMIC will automatically reset the interface when the clock > signal ceases for more than the SMBus timeout of 35 ms. > > If the I2C driver / device

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-02-22 Thread Lee Jones
On Sat, 20 Feb 2021, Wolfram Sang wrote: > > > Is the patch already on the way upstream? > > Can't really speak for Lee here, but during the merge window patches are > usually not applied. So, in something like 2 weeks, usually collecting > for the next cycle begins. Looking at the CC list, I

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-02-20 Thread Wolfram Sang
> Is the patch already on the way upstream? Can't really speak for Lee here, but during the merge window patches are usually not applied. So, in something like 2 weeks, usually collecting for the next cycle begins. Looking at the CC list, I think you added all the relevant people, so it seems

RE: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-02-09 Thread Adam Thomson
On 08 February 2021 15:28, Mark Jonas wrote: > From: Hubert Streidl > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > means the PMIC will automatically reset the interface when the clock > signal ceases for more than the SMBus timeout of 35 ms. > > If the I2C driver /

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-02-09 Thread Wolfram Sang
On Mon, Feb 08, 2021 at 04:27:58PM +0100, Mark Jonas wrote: > From: Hubert Streidl > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > means the PMIC will automatically reset the interface when the clock > signal ceases for more than the SMBus timeout of 35 ms. > > If the