Re: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 6:02 PM, wrote: >> > - if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) >> > - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid >> > signature >> (%8ph)\n", >> > + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) { >> > +

RE: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures

2017-10-05 Thread Mario.Limonciello
ael J. Wysocki > ; mj...@google.com; Christoph Hellwig ; > Greg KH > Subject: Re: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of > some > failures > > On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello > wrote: > > There is a lot of error checking in place f

Re: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures

2017-10-04 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello wrote: > There is a lot of error checking in place for the format of the WMI > descriptor buffer, but some of the potentially raised issues should > be considered critical failures. > > If the buffer size or header don't match, this is a good indic