Re: [PATCH v4 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Joe Perches
On Mon, 2012-12-03 at 20:20 +, Ortiz, Lance E wrote: > > > +#define correctable_error_string \ > > > + {BIT(0),"Receiver Error"}, \ > > > + {BIT(6),"Bad TLP"}, \ > > > + {BIT(7),"Bad DLLP"},\ > > > + {B

RE: [PATCH v4 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Ortiz, Lance E
> > +#define correctable_error_string \ > > + {BIT(0),"Receiver Error"}, \ > > + {BIT(6),"Bad TLP"}, \ > > + {BIT(7),"Bad DLLP"},\ > > + {BIT(8),"RELAY_NUM Rollover"}, \ > > + {

RE: [PATCH v4 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Ortiz, Lance E
> > +/* > > + * PCIe Advanced Error Reporting (AER) PCIE Report Error > > Why do you insist on keeping this convoluted compound name? What does > "PCIe AER PCIe Report Error" even mean? > > This is not unreadable technical documentation but something people > should actually understand. And it is

Re: [PATCH v4 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Joe Perches
On Mon, 2012-12-03 at 11:33 -0700, Lance Ortiz wrote: > This header file will define a new trace event that will be triggered when > a AER event occurs. The following data will be provided to the trace > event. trivial notes: > diff --git a/include/trace/events/ras.h b/include/trace/events/ras.h

Re: [PATCH v4 1/3] aerdrv: Trace Event for AER

2012-12-03 Thread Borislav Petkov
On Mon, Dec 03, 2012 at 11:33:05AM -0700, Lance Ortiz wrote: > This header file will define a new trace event that will be triggered when > a AER event occurs. The following data will be provided to the trace > event. > > char * dev_name - The name of the slot where the device resides >