RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-28 Thread Mani, Rajmohan
Hi Lee, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Tue, 25 Jul 2017, Mani, Rajmohan wrote: > > > Hi Lee, > > > > > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > > > > > On Fri, 21 Jul 2017,

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-28 Thread Mani, Rajmohan
Hi Andy, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Fri, Jul 28, 2017 at 3:30 AM, Mani, Rajmohan > wrote: > >> On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones > wrote: > >> > On Tue, 25 Jul 2017, Andy Shevchenko wrote: > >> &

Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-28 Thread Andy Shevchenko
On Fri, Jul 28, 2017 at 3:30 AM, Mani, Rajmohan wrote: >> On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones wrote: >> > On Tue, 25 Jul 2017, Andy Shevchenko wrote: >> >> On Tue, Jul 25, 2017 at 12:10 PM, Lee Jones wrote: >> >> >> I briefly checked few ->read() and ->write() implementations and >> >> d

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-27 Thread Mani, Rajmohan
Hi Lee, Andy, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones wrote: > > On Tue, 25 Jul 2017, Andy Shevchenko wrote: > >> On Tue, Jul 25, 2017 at 12:10 PM, Lee Jones wrote: > > >> I brie

Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-26 Thread Andy Shevchenko
On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones wrote: > On Tue, 25 Jul 2017, Andy Shevchenko wrote: >> On Tue, Jul 25, 2017 at 12:10 PM, Lee Jones wrote: >> I briefly checked few ->read() and ->write() implementations and >> didn't find any evidence of positive numbers that can be returned. >> Docu

Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-26 Thread Lee Jones
On Tue, 25 Jul 2017, Andy Shevchenko wrote: > On Tue, Jul 25, 2017 at 12:10 PM, Lee Jones wrote: > > On Fri, 21 Jul 2017, Mani, Rajmohan wrote: > >> > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > >> > > + /* Force software reset */ > >> > > + ret = regmap_write(regmap, TPS68470_REG_RESET, > >>

Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-26 Thread Lee Jones
On Tue, 25 Jul 2017, Mani, Rajmohan wrote: > Hi Lee, > > > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > > > On Fri, 21 Jul 2017, Mani, Rajmohan wrote: > > > > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > > > > > > >

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-25 Thread Mani, Rajmohan
Hi Lee, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Fri, 21 Jul 2017, Mani, Rajmohan wrote: > > > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > > > > > > The TPS68470 device is an advanced power management unit that > > >

Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-25 Thread Andy Shevchenko
On Tue, Jul 25, 2017 at 12:10 PM, Lee Jones wrote: > On Fri, 21 Jul 2017, Mani, Rajmohan wrote: >> > On Wed, 19 Jul 2017, Rajmohan Mani wrote: >> > > + /* Force software reset */ >> > > + ret = regmap_write(regmap, TPS68470_REG_RESET, >> > TPS68470_REG_RESET_MASK); >> > > + if (ret < 0) >> > >> >

Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-25 Thread Lee Jones
On Fri, 21 Jul 2017, Mani, Rajmohan wrote: > > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > > > > The TPS68470 device is an advanced power management unit that powers > > a > > > Compact Camera Module (CCM), generates clocks for image sensors, > > > drives a dual LED for Flash and incorporates tw

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-21 Thread Mani, Rajmohan
Hi Lee, > > > + * This program is free software; you can redistribute it and/or > > > + * modify it under the terms of the GNU General Public License as > > > + * published by the Free Software Foundation version 2. > > > + * > > > + * This program is distributed "as is" WITHOUT ANY WARRANTY of an

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-20 Thread Mani, Rajmohan
alleij ; Alexandre > Courbot ; Rafael J. Wysocki ; Len > Brown ; sakari.ai...@linux.intel.com; Andy Shevchenko > > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > > The TPS68470 device is an advanced power manag

Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-20 Thread Lee Jones
On Wed, 19 Jul 2017, Rajmohan Mani wrote: > The TPS68470 device is an advanced power management > unit that powers a Compact Camera Module (CCM), > generates clocks for image sensors, drives a dual > LED for Flash and incorporates two LED drivers for > general purpose indicators. > > This patch a