Re: [PATCH v4 1/5] net: Add support for hardware-offloaded encapsulation

2012-12-11 Thread Alexander Duyck
is >>> Cc: da...@davemloft.net; shemmin...@vyatta.com; chr...@sous-sol.org; >>> go...@redhat.com; net...@vger.kernel.org; linux-kernel@vger.kernel.org; >>> Dmitry Kravkov; bhutchi...@solarflare.com; Peter P Waskiewicz Jr; Alexander >>> Duyck >>> S

Re: [PATCH v4 1/5] net: Add support for hardware-offloaded encapsulation

2012-12-11 Thread saeed bishara
om; chr...@sous-sol.org; >> go...@redhat.com; net...@vger.kernel.org; linux-kernel@vger.kernel.org; >> Dmitry Kravkov; bhutchi...@solarflare.com; Peter P Waskiewicz Jr; Alexander >> Duyck >> Subject: Re: [PATCH v4 1/5] net: Add support for hardware-offloaded >> encapsulation &g

RE: [PATCH v4 1/5] net: Add support for hardware-offloaded encapsulation

2012-12-10 Thread Dmitry Kravkov
el@vger.kernel.org; > Dmitry Kravkov; bhutchi...@solarflare.com; Peter P Waskiewicz Jr; Alexander > Duyck > Subject: Re: [PATCH v4 1/5] net: Add support for hardware-offloaded > encapsulation > > > +static inline struct iphdr *inner_ip_hdr(const struct sk_buff *skb)

Re: [PATCH v4 1/5] net: Add support for hardware-offloaded encapsulation

2012-12-10 Thread Alexander Duyck
On 12/10/2012 02:04 AM, saeed bishara wrote: >> +static inline struct iphdr *inner_ip_hdr(const struct sk_buff *skb) >> +{ >> + return (struct iphdr *)skb_inner_network_header(skb); >> +} > Hi, > I'm a little bit bothered because of those inner_ functions, what > about the following approach:

Re: [PATCH v4 1/5] net: Add support for hardware-offloaded encapsulation

2012-12-10 Thread saeed bishara
> +static inline struct iphdr *inner_ip_hdr(const struct sk_buff *skb) > +{ > + return (struct iphdr *)skb_inner_network_header(skb); > +} Hi, I'm a little bit bothered because of those inner_ functions, what about the following approach: 1. the skb will have a new state, that state can be o