Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-22 Thread Andy Shevchenko
On Thu, 2016-12-22 at 14:59 +, Luis Oliveira wrote: > On 13-Dec-16 14:11, Rob Herring wrote: > > Something like this: > > > > of_for_each_child_node(child) { > >   of_property_read_u32(child, "reg", ); > >   if (reg & I2C_OWN_SLAVE_ADDRESS)) > > im_a_slave = true; > > } > > > >

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-22 Thread Andy Shevchenko
On Thu, 2016-12-22 at 14:59 +, Luis Oliveira wrote: > On 13-Dec-16 14:11, Rob Herring wrote: > > Something like this: > > > > of_for_each_child_node(child) { > >   of_property_read_u32(child, "reg", ); > >   if (reg & I2C_OWN_SLAVE_ADDRESS)) > > im_a_slave = true; > > } > > > >

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-22 Thread Luis Oliveira
t; -Original Message- >> From: Rob Herring [mailto:r...@kernel.org] >> Sent: Monday, December 12, 2016 23:16 >> To: Luis de Oliveira <luis.olive...@synopsys.com> >> Cc: w...@the-dreams.de; mark.rutl...@arm.com; jarkko.nik...@linux.intel.com; >> andriy.shevche

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-22 Thread Luis Oliveira
om: Rob Herring [mailto:r...@kernel.org] >> Sent: Monday, December 12, 2016 23:16 >> To: Luis de Oliveira >> Cc: w...@the-dreams.de; mark.rutl...@arm.com; jarkko.nik...@linux.intel.com; >> andriy.shevche...@linux.intel.com; mika.westerb...@linux.intel.com; >> linux

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-13 Thread Rob Herring
ux.intel.com; > linux-...@vger.kernel.org; devicet...@vger.kernel.org; > linux-kernel@vger.kernel.org; ramiro.olive...@synopsys.com; > joao.pi...@synopsys.com; carlos.palmi...@synopsys.com > Subject: Re: [PATCH v4 3/5] i2c: designware: Add slave definitions > > On Mon, Dec 12,

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-13 Thread Rob Herring
org; > linux-kernel@vger.kernel.org; ramiro.olive...@synopsys.com; > joao.pi...@synopsys.com; carlos.palmi...@synopsys.com > Subject: Re: [PATCH v4 3/5] i2c: designware: Add slave definitions > > On Mon, Dec 12, 2016 at 12:35 PM, Luis de Oliveira > wrote: >> Hi all, &g

RE: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-13 Thread Luis de Oliveira
...@linux.intel.com; andriy.shevche...@linux.intel.com; mika.westerb...@linux.intel.com; linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; ramiro.olive...@synopsys.com; joao.pi...@synopsys.com; carlos.palmi...@synopsys.com Subject: Re: [PATCH v4 3/5] i2c: designware

RE: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-13 Thread Luis de Oliveira
@linux.intel.com; mika.westerb...@linux.intel.com; linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; ramiro.olive...@synopsys.com; joao.pi...@synopsys.com; carlos.palmi...@synopsys.com Subject: Re: [PATCH v4 3/5] i2c: designware: Add slave definitions On Mon, Dec

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-12 Thread Rob Herring
On Mon, Dec 12, 2016 at 12:35 PM, Luis de Oliveira wrote: > Hi all, Please don't top post. > > The slave address could be set by the I2C slave backend so I can't use it to > setup the controller. > A boolean property was my initial approach then Andy and Wolfram

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-12 Thread Rob Herring
On Mon, Dec 12, 2016 at 12:35 PM, Luis de Oliveira wrote: > Hi all, Please don't top post. > > The slave address could be set by the I2C slave backend so I can't use it to > setup the controller. > A boolean property was my initial approach then Andy and Wolfram Sang > suggested the use of

RE: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-12 Thread Luis de Oliveira
rm.com; jarkko.nik...@linux.intel.com; andriy.shevche...@linux.intel.com; mika.westerb...@linux.intel.com; linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; ramiro.olive...@synopsys.com; joao.pi...@synopsys.com; carlos.palmi...@synopsys.com Subject: Re: [PATCH v4 3/

RE: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-12 Thread Luis de Oliveira
; andriy.shevche...@linux.intel.com; mika.westerb...@linux.intel.com; linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; ramiro.olive...@synopsys.com; joao.pi...@synopsys.com; carlos.palmi...@synopsys.com Subject: Re: [PATCH v4 3/5] i2c: designware: Add slave

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-12 Thread Rob Herring
On Wed, Dec 07, 2016 at 05:55:50PM +, Luis Oliveira wrote: > - Add slave definitions to i2c-designware-core > - Changes in Kconfig to auto-enable I2C_SLAVE when compiling the modules > - Add mode property to designware-core.txt that enable the "slave" selection: > - "mode" is an optional

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-12 Thread Rob Herring
On Wed, Dec 07, 2016 at 05:55:50PM +, Luis Oliveira wrote: > - Add slave definitions to i2c-designware-core > - Changes in Kconfig to auto-enable I2C_SLAVE when compiling the modules > - Add mode property to designware-core.txt that enable the "slave" selection: > - "mode" is an optional

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-07 Thread Andy Shevchenko
On Wed, 2016-12-07 at 17:55 +, Luis Oliveira wrote: > - Add slave definitions to i2c-designware-core > - Changes in Kconfig to auto-enable I2C_SLAVE when compiling the > modules > - Add mode property to designware-core.txt that enable the "slave" > selection: >   - "mode" is an optional

Re: [PATCH v4 3/5] i2c: designware: Add slave definitions

2016-12-07 Thread Andy Shevchenko
On Wed, 2016-12-07 at 17:55 +, Luis Oliveira wrote: > - Add slave definitions to i2c-designware-core > - Changes in Kconfig to auto-enable I2C_SLAVE when compiling the > modules > - Add mode property to designware-core.txt that enable the "slave" > selection: >   - "mode" is an optional