Re: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

2021-02-10 Thread nakamura.s...@fujitsu.com
Hi, John >> I will resend based on tmp.perf/core. > > Actually it is now on perf/core, so that is a better baseline. I will resend based on perf/core. > > I will send it in HTML format. > > Hmmm, that's not better. I think that the mail servers reject html. > > Please consult Documentation/proc

Re: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

2021-02-10 Thread John Garry
On 10/02/2021 15:34, nakamura.s...@fujitsu.com wrote: Hi, John So my series is now on remotes/origin/tmp.perf/core in Arnaldo's acme git, so you could resend against that. https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git Or again, put my series on perf/core and se

Re: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

2021-02-08 Thread John Garry
On 08/02/2021 01:53, nakamur'd a.s...@fujitsu.com wrote: Hi, John Apart from that, I think that we're a bit uncertain about patch 3/4 What are your concerns? I think it's okay for perf to read a new event code with a number at the beginning. The impact of this fix is on {name} and later rule

RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

2021-02-07 Thread nakamura.s...@fujitsu.com
Hi, John > > > Apart from that, I think that we're a bit uncertain about patch 3/4 > > What are your concerns? > > I think it's okay for perf to read a new event code with a number at the > beginning. > > The impact of this fix is on {name} and later rules. > parse_events.l uses {name} only in on

RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

2021-02-05 Thread nakamura.s...@fujitsu.com
l.org; > mathieu.poir...@linaro.org; leo@linaro.org; pet...@infradead.org; > mi...@redhat.com; a...@kernel.org; mark.rutl...@arm.com; > alexander.shish...@linux.intel.com; jo...@redhat.com; namhy...@kernel.org > Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org > S

RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

2021-02-02 Thread nakamura.s...@fujitsu.com
Hi, John > Just some things to note: > - please pick up and apply reviewed-by tags granted from previous reviews if > explicitly granted, subject to making any trivial changes requested If any > significant changes are made, then don't pick up theses tags or drop them (if > they > were picked up

Re: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

2021-02-02 Thread John Garry
On 02/02/2021 12:51, Shunsuke Nakamura wrote: From: Shunsuke Nakamura This patch series supports A64FX PMU event v1.2. The first patch adds a common and microarchitecture event, which can be referenced from CPU JSONs. This patch uses part of John's patch.[1] The second patch add more common a