Re: [PATCH v5 09/17] tpm: move tpm_validate_commmand() to tpm2-space.c

On Thu, Nov 08, 2018 at 05:03:29PM +, Winkler, Tomas wrote: > You initialized cc under if only > > + > > + i = tpm2_find_cc(chip, cc); > > + if (i < 0) { > > + dev_dbg(&chip->dev, "0x%04X is an invalid > > command\n", > > + cc); >

RE: [PATCH v5 09/17] tpm: move tpm_validate_commmand() to tpm2-space.c

> > Move tpm_validate_command() to tpm2-space.c and make it part of the > tpm2_prepare_space() flow. Make cc resolution as part of the TPM space > functionality in order to detach it from rest of the tpm_transmit() flow. > > Signed-off-by: Jarkko Sakkinen > Reviewed-by: Stefan Berger > --- >