el.org; linux-arm-ker...@lists.infradead.org; linux-
> >i...@vger.kernel.org; Li Frank-B20596
> >Subject: RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c
> >driver
> >
> >Hi Fugang,
> >
> >> >> >+ /* Waiting for Transfer co
rnel.org; Li Frank-B20596
>Subject: RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c
>driver
>
>Hi Fugang,
>
>> >> >+/* Waiting for Transfer complete. */
>> >> >+while (timeout--) {
>> >> >+te
Hi Fugang,
> >> >+ /* Waiting for Transfer complete. */
> >> >+ while (timeout--) {
> >> >+ temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR);
> >> >+ if (temp & I2SR_ICF)
> >> >+ break;
> >> >+ udelay(10);
> >> >+ }
> >> Whether there have better method like i
rnel.org; Li Frank-B20596
>Subject: RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c
>driver
>
>Hi Fugang,
>
>Duan Fugang wrote:
>[...]
>>+ dma_sconfig.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
>>+ dma_sconfig.dst_maxburst = 1;
>> The ma
> > static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx,
> > struct i2c_msg *msgs)
> >
> > run checkpatch.pl on this patch...
>
> Sorry for my code style. I will match open parenthesis in this case.
FYI, I am not strict on the open parenthesis thingie.
signatu
Hi Fugang,
Duan Fugang wrote:
[...]
>+ dma_sconfig.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
>+ dma_sconfig.dst_maxburst = 1;
> The maxburst is 1 cause very slow efficiency for DMA copy, which system
> performance even is slower Than cpu mode.
There is no FIFO for IMX i2c, so the maxb
From: Yuan Yao Data: Tuesday, August 05, 2014 5:56 PM
>To: w...@the-dreams.de; ma...@denx.de
>Cc: l...@karo-electronics.de; mark.rutl...@arm.com; shawn@linaro.org;
>linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
>i...@vger.kernel.org
>Subject: [PATCH v6 1/2] i2c: im
Thanks for your review.
Varka Bhadram wrote:
> On 08/05/2014 03:26 PM, Yuan Yao wrote:
>
> (...)
> > +fail_rx:
> > + dma_release_channel(dma->chan_rx);
> > +fail_tx:
> > + dma_release_channel(dma->chan_tx);
> > +fail_al:
> > + devm_kfree(dev, dma);
>
> no need to use devm_kfree() if we use
On 08/05/2014 03:26 PM, Yuan Yao wrote:
(...)
+/* Functions for DMA support */
+static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
+ dma_addr_t phy_addr)
should match open parenthesis...
static int i2c_imx_dma_request(struct imx_i2c_s
9 matches
Mail list logo
