RE: [PATCH v6 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-11 Thread Yuan, Perry
rg; platform-driver- > x...@vger.kernel.org; mario.limoncie...@outlook.com; Dell Client Kernel > Subject: Re: [PATCH v6 1/2] platform/x86: dell-privacy: Add support for Dell > hardware privacy > > > [EXTERNAL EMAIL] > > Hi Perry, Barnabás, > > Barnabás thank you for your re

Re: [PATCH v6 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-07 Thread Hans de Goede
Hi Perry, Barnabás, Barnabás thank you for your review. I agree with all your remarks. Perry, Thank you for the new version, this version is looking good. This is almost ready for merging. Please fix the review remarks from Barnabás. I also have a couple of small review remarks myself below. On

RE: [PATCH v6 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-05 Thread Limonciello, Mario
> > I think this could be `dev_info()`, but definitely not `dev_err()`. Although > I'd > personally move the logging from here to the probe function if you want to log > which features are available. `ret` is necessarily 1 here, so I don't think > printing it > provides additional information. To

Re: [PATCH v6 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-04 Thread Barnabás Pőcze
Hi 2021. április 4., vasárnap 10:31 keltezéssel, Perry Yuan írta: > From: Perry Yuan > > add support for Dell privacy driver for the Dell units equipped > hardware privacy design, which protect users privacy of audio and > camera from hardware level. Once the audio or camera privacy mode > acti