RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-12 Thread Liu Qiang-B32616
> >> Will this engine be coordinating with another to handle memory copies? > >> The dma mapping code for async_tx/raid is broken when dma mapping > >> requests overlap or cross dma device boundaries [1]. > >> > >> [1]: http://marc.info/?l=linux-arm-kernel=129407269402930=2 > > Yes, it needs

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-12 Thread Liu Qiang-B32616
Will this engine be coordinating with another to handle memory copies? The dma mapping code for async_tx/raid is broken when dma mapping requests overlap or cross dma device boundaries [1]. [1]: http://marc.info/?l=linux-arm-kernelm=129407269402930w=2 Yes, it needs fsl-dma to handle

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-04 Thread Dan Williams
On Tue, Sep 4, 2012 at 5:28 AM, Liu Qiang-B32616 wrote: >> Will this engine be coordinating with another to handle memory copies? >> The dma mapping code for async_tx/raid is broken when dma mapping >> requests overlap or cross dma device boundaries [1]. >> >> [1]:

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-04 Thread Liu Qiang-B32616
oft.net; linux-kernel@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; Li Yang-R58472; Phillips Kim-R1AAHA; > vinod.k...@intel.com; dan.j.willi...@intel.com; a...@arndb.de; > gre...@linuxfoundation.org > Subject: Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload > >

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-04 Thread Liu Qiang-B32616
@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; Li Yang-R58472; Phillips Kim-R1AAHA; vinod.k...@intel.com; dan.j.willi...@intel.com; a...@arndb.de; gre...@linuxfoundation.org Subject: Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload On Thu, Aug 9, 2012 at 1:20 AM, qiang@freescale.com

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-04 Thread Dan Williams
On Tue, Sep 4, 2012 at 5:28 AM, Liu Qiang-B32616 b32...@freescale.com wrote: Will this engine be coordinating with another to handle memory copies? The dma mapping code for async_tx/raid is broken when dma mapping requests overlap or cross dma device boundaries [1]. [1]:

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-02 Thread Dan Williams
On Thu, Aug 9, 2012 at 1:20 AM, wrote: > From: Qiang Liu > > Expose Talitos's XOR functionality to be used for RAID parity > calculation via the Async_tx layer. > > Cc: Herbert Xu > Cc: David S. Miller > Signed-off-by: Dipen Dudhat > Signed-off-by: Maneesh Gupta > Signed-off-by: Kim

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-02 Thread Dan Williams
On Thu, Aug 30, 2012 at 7:23 AM, Geanta Neag Horia Ioan-B05471 wrote: > > Besides these: > 1. As Dan Williams mentioned, you should explain why you are using > both spin_lock_bh and spin_lock_irqsave on the same lock. It looks like talitos_process_pending() can be called from hardirq context via

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-02 Thread Dan Williams
On Thu, Aug 30, 2012 at 7:23 AM, Geanta Neag Horia Ioan-B05471 b05...@freescale.com wrote: Besides these: 1. As Dan Williams mentioned, you should explain why you are using both spin_lock_bh and spin_lock_irqsave on the same lock. It looks like talitos_process_pending() can be called from

Re: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-09-02 Thread Dan Williams
On Thu, Aug 9, 2012 at 1:20 AM, qiang@freescale.com wrote: From: Qiang Liu qiang@freescale.com Expose Talitos's XOR functionality to be used for RAID parity calculation via the Async_tx layer. Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-31 Thread Liu Qiang-B32616
org; linuxppc- > d...@lists.ozlabs.org > Cc: Li Yang-R58472; Phillips Kim-R1AAHA; vinod.k...@intel.com; Dan > Williams; a...@arndb.de; gre...@linuxfoundation.org > Subject: RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload > > On Fri, 31 Aug 2012 06:08:05 +0300, Liu Qiang-B32616 >

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-31 Thread Geanta Neag Horia Ioan-B05471
; herb...@gondor.hengli.com.au; > > da...@davemloft.net; linux-kernel@vger.kernel.org; linuxppc- > > d...@lists.ozlabs.org > > Cc: Li Yang-R58472; Phillips Kim-R1AAHA; vinod.k...@intel.com; > > dan.j.willi...@intel.com; a...@arndb.de; gre...@linuxfoundation.org; Liu > > Q

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-31 Thread Geanta Neag Horia Ioan-B05471
...@gondor.hengli.com.au; da...@davemloft.net; linux-kernel@vger.kernel.org; linuxppc- d...@lists.ozlabs.org Cc: Li Yang-R58472; Phillips Kim-R1AAHA; vinod.k...@intel.com; dan.j.willi...@intel.com; a...@arndb.de; gre...@linuxfoundation.org; Liu Qiang-B32616 Subject: RE: [PATCH v7 1/8] Talitos: Support

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-31 Thread Liu Qiang-B32616
Cc: Li Yang-R58472; Phillips Kim-R1AAHA; vinod.k...@intel.com; Dan Williams; a...@arndb.de; gre...@linuxfoundation.org Subject: RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload On Fri, 31 Aug 2012 06:08:05 +0300, Liu Qiang-B32616 b32...@freescale.com wrote: -Original

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-30 Thread Liu Qiang-B32616
org; linuxppc- > d...@lists.ozlabs.org > Cc: Li Yang-R58472; Phillips Kim-R1AAHA; vinod.k...@intel.com; > dan.j.willi...@intel.com; a...@arndb.de; gre...@linuxfoundation.org; Liu > Qiang-B32616 > Subject: RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload > > O

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-30 Thread Geanta Neag Horia Ioan-B05471
On Thu, 9 Aug 2012 11:20:48 +0300, qiang@freescale.com wrote: > From: Qiang Liu > > Expose Talitos's XOR functionality to be used for RAID parity > calculation via the Async_tx layer. > > Cc: Herbert Xu > Cc: David S. Miller > Signed-off-by: Dipen Dudhat > Signed-off-by: Maneesh Gupta >

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-30 Thread Geanta Neag Horia Ioan-B05471
On Thu, 9 Aug 2012 11:20:48 +0300, qiang@freescale.com wrote: From: Qiang Liu qiang@freescale.com Expose Talitos's XOR functionality to be used for RAID parity calculation via the Async_tx layer. Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net

RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload

2012-08-30 Thread Liu Qiang-B32616
...@lists.ozlabs.org Cc: Li Yang-R58472; Phillips Kim-R1AAHA; vinod.k...@intel.com; dan.j.willi...@intel.com; a...@arndb.de; gre...@linuxfoundation.org; Liu Qiang-B32616 Subject: RE: [PATCH v7 1/8] Talitos: Support for async_tx XOR offload On Thu, 9 Aug 2012 11:20:48 +0300, qiang@freescale.com wrote