Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-25 Thread Dou Liyang
Hi Rafael, At 08/25/2017 08:27 PM, Rafael J. Wysocki wrote: On Friday, August 25, 2017 4:06:11 AM CEST Dou Liyang wrote: [...] BTW, 1) I found your commit b064a8fa77df (" ACPI / init: Switch over platform to the ACPI mode later") split the ACPI early initialization code into acpi_early_init()

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-25 Thread Rafael J. Wysocki
On Friday, August 25, 2017 4:06:11 AM CEST Dou Liyang wrote: > Hi Rafael, > > At 08/25/2017 12:38 AM, Rafael J. Wysocki wrote: > > On Thursday, August 24, 2017 5:54:28 AM CEST Dou Liyang wrote: > >> Hi Rafael, Zheng, > >> > >> At 07/31/2017 06:50 PM, Dou Liyang wrote: > >>> Hi, > >>> > >>> At 07/1

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-24 Thread Dou Liyang
Hi Rafael, At 08/25/2017 12:38 AM, Rafael J. Wysocki wrote: On Thursday, August 24, 2017 5:54:28 AM CEST Dou Liyang wrote: Hi Rafael, Zheng, At 07/31/2017 06:50 PM, Dou Liyang wrote: Hi, At 07/14/2017 01:52 PM, Dou Liyang wrote: Linux uses acpi_early_init() to put the ACPI table management

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-24 Thread Rafael J. Wysocki
On Thursday, August 24, 2017 5:54:28 AM CEST Dou Liyang wrote: > Hi Rafael, Zheng, > > At 07/31/2017 06:50 PM, Dou Liyang wrote: > > Hi, > > > > At 07/14/2017 01:52 PM, Dou Liyang wrote: > >> Linux uses acpi_early_init() to put the ACPI table management into > >> the late stage from the early stag

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-24 Thread Dou Liyang
At 08/24/2017 06:21 PM, Baoquan He wrote: On 08/24/17 at 05:28pm, Dou Liyang wrote: Hi Baoquan, Thanks for your reply. At 08/24/2017 04:05 PM, Baoquan He wrote: Hi Liyang, On 08/24/17 at 11:54am, Dou Liyang wrote: Test in my own PC(Lenovo M4340). Ask help for doing regression testing for

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-24 Thread Baoquan He
On 08/24/17 at 05:28pm, Dou Liyang wrote: > Hi Baoquan, > > Thanks for your reply. > > At 08/24/2017 04:05 PM, Baoquan He wrote: > > Hi Liyang, > > > > On 08/24/17 at 11:54am, Dou Liyang wrote: > > > > > Test in my own PC(Lenovo M4340). > > > > > Ask help for doing regression testing for the bug

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-24 Thread Dou Liyang
Hi Baoquan, Thanks for your reply. At 08/24/2017 04:05 PM, Baoquan He wrote: Hi Liyang, On 08/24/17 at 11:54am, Dou Liyang wrote: Test in my own PC(Lenovo M4340). Ask help for doing regression testing for the bug said in commit c4e1acbb35e4 ("ACPI / init: Invoke early ACPI initialization late

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-24 Thread Baoquan He
Hi Liyang, On 08/24/17 at 11:54am, Dou Liyang wrote: > > > Test in my own PC(Lenovo M4340). > > > Ask help for doing regression testing for the bug said in commit > > > c4e1acbb35e4 > > > ("ACPI / init: Invoke early ACPI initialization later"). > > > > > > > Now, I can prove this patch doesn't r

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-08-23 Thread Dou Liyang
Hi Rafael, Zheng, At 07/31/2017 06:50 PM, Dou Liyang wrote: Hi, At 07/14/2017 01:52 PM, Dou Liyang wrote: Linux uses acpi_early_init() to put the ACPI table management into the late stage from the early stage where the mapped ACPI tables is temporary and should be unmapped. But, now initializ

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-31 Thread b...@redhat.com
On 07/31/17 at 07:20pm, Dou Liyang wrote: > Hi Baoquan, > > At 07/27/2017 02:08 PM, b...@redhat.com wrote: > > On 07/26/17 at 08:19pm, Dou Liyang wrote: > > > Hi Baoquan, > [...] > > > > > > I am looking for Thinkpad x121e (AMD E-450 APU) to test. I have tested > > > it in Thinkpad s430, It's OK.

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-31 Thread Dou Liyang
Hi Baoquan, At 07/27/2017 02:08 PM, b...@redhat.com wrote: On 07/26/17 at 08:19pm, Dou Liyang wrote: Hi Baoquan, [...] I am looking for Thinkpad x121e (AMD E-450 APU) to test. I have tested it in Thinkpad s430, It's OK. BTY, I am confused how does the ACPI subsystem affect PIT which will be

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-31 Thread Dou Liyang
Hi, At 07/14/2017 01:52 PM, Dou Liyang wrote: Linux uses acpi_early_init() to put the ACPI table management into the late stage from the early stage where the mapped ACPI tables is temporary and should be unmapped. But, now initializing interrupt delivery mode should map and parse the DMAR tabl

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-27 Thread Dou Liyang
Hi, Zheng At 07/28/2017 09:53 AM, Zheng, Lv wrote: [...] Dmar hardware support interrupt remapping and io remapping separately. But intel_iommu_init() is called later than intel_prepare_irq_remapping(). So what if make dmar_table_init() a reentrant function? You can just have a try, but maybe

RE: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-27 Thread Zheng, Lv
Hi, > From: Dou Liyang [mailto:douly.f...@cn.fujitsu.com] > Sent: Tuesday, July 18, 2017 5:44 PM > Subject: Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization > earlier > > Hi Baoquan, > > At 07/18/2017 04:45 PM, b...@redhat.com wrote: > > On 0

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-26 Thread Dou Liyang
Hi Baoquan, At 07/27/2017 02:08 PM, b...@redhat.com wrote: On 07/26/17 at 08:19pm, Dou Liyang wrote: Hi Baoquan, There are two places where we used DMAR table in Linux: 1) In detect_intel_iommu() in ACPI early stage: ... status = acpi_get_table(ACPI_SIG_DMAR, 0, &dmar_tbl); if (dmar_tbl

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-26 Thread b...@redhat.com
On 07/26/17 at 08:19pm, Dou Liyang wrote: > Hi Baoquan, > > > There are two places where we used DMAR table in Linux: > > > > > > 1) In detect_intel_iommu() in ACPI early stage: > > > > > > ... > > > status = acpi_get_table(ACPI_SIG_DMAR, 0, &dmar_tbl); > > > > > > if (dmar_tbl) { > > > ac

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-26 Thread Dou Liyang
Hi Baoquan, At 07/18/2017 04:45 PM, b...@redhat.com wrote: On 07/18/17 at 02:08pm, Dou Liyang wrote: Hi, Zheng At 07/18/2017 01:18 PM, Zheng, Lv wrote: Hi, Can the problem be fixed by invoking acpi_put_table() for mapped DMAR table? Invoking acpi_put_table() is my first choice. But it made

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-18 Thread Dou Liyang
Hi Baoquan, At 07/18/2017 04:45 PM, b...@redhat.com wrote: On 07/18/17 at 02:08pm, Dou Liyang wrote: Hi, Zheng At 07/18/2017 01:18 PM, Zheng, Lv wrote: Hi, Can the problem be fixed by invoking acpi_put_table() for mapped DMAR table? Invoking acpi_put_table() is my first choice. But it made

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-18 Thread b...@redhat.com
On 07/18/17 at 02:08pm, Dou Liyang wrote: > Hi, Zheng > > At 07/18/2017 01:18 PM, Zheng, Lv wrote: > > Hi, > > > > Can the problem be fixed by invoking acpi_put_table() for mapped DMAR table? > > Invoking acpi_put_table() is my first choice. But it made the kernel > *panic* when we try to get th

Re: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-17 Thread Dou Liyang
Hi, Zheng At 07/18/2017 01:18 PM, Zheng, Lv wrote: Hi, Can the problem be fixed by invoking acpi_put_table() for mapped DMAR table? Invoking acpi_put_table() is my first choice. But it made the kernel *panic* when we try to get the table again in intel_iommu_init() in late stage. I am also c

RE: [PATCH v7 12/13] ACPI / init: Invoke early ACPI initialization earlier

2017-07-17 Thread Zheng, Lv
Hi, Can the problem be fixed by invoking acpi_put_table() for mapped DMAR table? Thanks Lv > From: Dou Liyang [mailto:douly.f...@cn.fujitsu.com] > Sent: Friday, July 14, 2017 1:53 PM > To: x...@kernel.org; linux-kernel@vger.kernel.org > Cc: t...@linutronix.de; mi...@kernel.org; h...@zytor.com;