RE: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-16 Thread Cho KyongHo
> From: grund...@google.com [mailto:grund...@google.com] On Behalf Of Grant > Grundler > Sent: Tuesday, July 16, 2013 1:19 AM > > On Mon, Jul 15, 2013 at 4:21 AM, Cho KyongHo wrote: > ... > >> Maybe you could add LV1TABLE_SIZE define and use it here (there is > >> already a LV2TABLE_SIZE

RE: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-16 Thread Cho KyongHo
From: grund...@google.com [mailto:grund...@google.com] On Behalf Of Grant Grundler Sent: Tuesday, July 16, 2013 1:19 AM On Mon, Jul 15, 2013 at 4:21 AM, Cho KyongHo pullip@samsung.com wrote: ... Maybe you could add LV1TABLE_SIZE define and use it here (there is already a

Re: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-15 Thread Grant Grundler
On Mon, Jul 15, 2013 at 4:21 AM, Cho KyongHo wrote: ... >> Maybe you could add LV1TABLE_SIZE define and use it here (there is >> already a LV2TABLE_SIZE define)? > > Yes. But, LV2TABLE_SIZE is used in more places than one. > I do not feel that it is needed to define LV1TABLE_SIZE for the single

RE: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-15 Thread Cho KyongHo
> -Original Message- > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Friday, July 12, 2013 2:38 AM > > Hi, > > Some minor nitpicks below. > > On Friday, July 05, 2013 09:29:18 PM Cho KyongHo wrote: > > This prevents allocating lv2 page table for the lv1 page

RE: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-15 Thread Cho KyongHo
-Original Message- From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] Sent: Friday, July 12, 2013 2:38 AM Hi, Some minor nitpicks below. On Friday, July 05, 2013 09:29:18 PM Cho KyongHo wrote: This prevents allocating lv2 page table for the lv1 page table entry

Re: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-15 Thread Grant Grundler
On Mon, Jul 15, 2013 at 4:21 AM, Cho KyongHo pullip@samsung.com wrote: ... Maybe you could add LV1TABLE_SIZE define and use it here (there is already a LV2TABLE_SIZE define)? Yes. But, LV2TABLE_SIZE is used in more places than one. I do not feel that it is needed to define LV1TABLE_SIZE

Re: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-11 Thread Bartlomiej Zolnierkiewicz
Hi, Some minor nitpicks below. On Friday, July 05, 2013 09:29:18 PM Cho KyongHo wrote: > This prevents allocating lv2 page table for the lv1 page table entry > that already has 1MB page mapping. In addition some BUG_ON() is > changed to WARN_ON(). > > Signed-off-by: Cho KyongHo > --- >

Re: [PATCH v7 3/9] iommu/exynos: fix page table maintenance

2013-07-11 Thread Bartlomiej Zolnierkiewicz
Hi, Some minor nitpicks below. On Friday, July 05, 2013 09:29:18 PM Cho KyongHo wrote: This prevents allocating lv2 page table for the lv1 page table entry that already has 1MB page mapping. In addition some BUG_ON() is changed to WARN_ON(). Signed-off-by: Cho KyongHo