Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-31 Thread Baolin Wang
On 31 March 2016 at 16:15, Felipe Balbi wrote: > > Hi Baolin, > > Baolin Wang writes: >> Make sense. In our company's solution, charger detection can be done >> by hardware from PMIC at first, then it will not affect the DP/DM >> line when gadget starts to enumeration. >

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-31 Thread Felipe Balbi
Hi Baolin, Baolin Wang writes: >>> >> Make sense. In our company's solution, charger detection can be done >>> >> by hardware from PMIC at first, then it will not affect the DP/DM >>> >> line when gadget starts to enumeration. >>> > >>> > I see, charger type detection is done automatically by PM

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
n...@lists.linuxfoundation.org; LKML > ker...@vger.kernel.org> >> Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with >> the usb gadget power negotation >> >> On 30 March 2016 at 18:58, Jun Li wrote: >> >> >> >> > Seem

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 31 March 2016 at 14:18, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> [ text/plain ] >> On 30 March 2016 at 19:24, Felipe Balbi wrote: > >> >> > > >> >> > Seems you don't want to guarantee charger type detection is done > >> >> > before gadget connection(pullup DP), right

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Felipe Balbi
Hi, Baolin Wang writes: > [ text/plain ] > On 30 March 2016 at 19:24, Felipe Balbi wrote: >> >> > >> >> > Seems you don't want to guarantee charger type detection is done >> >> > before gadget connection(pullup DP), right? >> >> > I see you call usb_charger_detect_type() in

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Jun Li
; Alan Stern > ; r.bald...@samsung.com; Yoshihiro Shimoda > ; Lee Jones ; Mark > Brown ; Charles Keepax > ; patc...@opensource.wolfsonmicro.com; > Linux PM list ; USB ; > device-mainlin...@lists.linuxfoundation.org; LKML ker...@vger.kernel.org> > Subject: Re: [PATCH v8 0/4] Introd

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 19:24, Felipe Balbi wrote: >>> >> >> > >>> >> >> > Seems you don't want to guarantee charger type detection is done >>> >> >> > before gadget connection(pullup DP), right? >>> >> >> > I see you call usb_charger_detect_type() in each gadget usb >>> >> >> > state >>> >> >> change

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 18:58, Jun Li wrote: >> >> >> > Seems you don't want to guarantee charger type detection is done >> >> >> > before gadget connection(pullup DP), right? >> >> >> > I see you call usb_charger_detect_type() in each gadget usb >> >> >> > state >> >> >> changes. >> >> >> >> >> >> I

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Felipe Balbi
LKML > ker...@vger.kernel.org> >> Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with >> the usb gadget power negotation >> >> On 30 March 2016 at 16:07, Jun Li wrote: >> > Hi >> >> >> On 30 Marc

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Jun Li
; Alan Stern > ; r.bald...@samsung.com; Yoshihiro Shimoda > ; Lee Jones ; Mark > Brown ; Charles Keepax > ; patc...@opensource.wolfsonmicro.com; > Linux PM list ; USB ; > device-mainlin...@lists.linuxfoundation.org; LKML ker...@vger.kernel.org> > Subject: Re: [PATCH v8 0/4] Introd

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 17:19, Peter Chen wrote: > On Wed, Mar 30, 2016 at 04:40:31PM +0800, Baolin Wang wrote: >> >> > - Third, since composite driver covers 500mA (and more for CDP) after >> >> > set >> >> > configuration and 2mA after suspend, and vbus handler covers connect >> >> > and disconnect

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 16:07, Jun Li wrote: > Hi >> On 30 March 2016 at 10:54, Jun Li wrote: >> >> >> It is not for udc driver but for power users who want to negotiate >> >> >> with USB subsystem. >> >> >> >> >> > >> >> > Seems you don't want to guarantee charger type detection is done >> >> > bef

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Peter Chen
On Wed, Mar 30, 2016 at 04:40:31PM +0800, Baolin Wang wrote: > >> > - Third, since composite driver covers 500mA (and more for CDP) after set > >> > configuration and 2mA after suspend, and vbus handler covers connect > >> > and disconnect. I can't see any reasons we need to notify gadget state > >

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Jun Li
; Alan Stern > ; r.bald...@samsung.com; Yoshihiro Shimoda > ; Lee Jones ; Mark > Brown ; Charles Keepax > ; patc...@opensource.wolfsonmicro.com; > Linux PM list ; USB ; > device-mainlin...@lists.linuxfoundation.org; LKML ker...@vger.kernel.org> > Subject: Re: [PATCH v8 0/4] Introd

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 15:42, Peter Chen wrote: > On Wed, Mar 30, 2016 at 03:07:49PM +0800, Baolin Wang wrote: >> On 30 March 2016 at 10:05, Peter Chen wrote: >> > On Tue, Mar 29, 2016 at 10:23:14AM -0700, Mark Brown wrote: >> >> On Mon, Mar 28, 2016 at 03:13:51PM +0800, Peter Chen wrote: >> >> > On

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Peter Chen
On Wed, Mar 30, 2016 at 03:07:49PM +0800, Baolin Wang wrote: > On 30 March 2016 at 10:05, Peter Chen wrote: > > On Tue, Mar 29, 2016 at 10:23:14AM -0700, Mark Brown wrote: > >> On Mon, Mar 28, 2016 at 03:13:51PM +0800, Peter Chen wrote: > >> > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 10:05, Peter Chen wrote: > On Tue, Mar 29, 2016 at 10:23:14AM -0700, Mark Brown wrote: >> On Mon, Mar 28, 2016 at 03:13:51PM +0800, Peter Chen wrote: >> > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: >> >> > > > I am afraid I still not find the user (udc driver)

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-29 Thread Baolin Wang
On 30 March 2016 at 10:54, Jun Li wrote: >> >> It is not for udc driver but for power users who want to negotiate >> >> with USB subsystem. >> >> >> > >> > Seems you don't want to guarantee charger type detection is done >> > before gadget connection(pullup DP), right? >> > I see you call usb_char

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-29 Thread Jun Li
..@samsung.com; Yoshihiro > >> Shimoda ; Lee Jones > >> ; Mark Brown ; Charles > >> Keepax ; > >> patc...@opensource.wolfsonmicro.com; > >> Linux PM list ; USB > >> ; > >> device-mainlin...@lists.linuxfoundation.org; LKML >> ker...@v

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-29 Thread Peter Chen
On Tue, Mar 29, 2016 at 10:23:14AM -0700, Mark Brown wrote: > On Mon, Mar 28, 2016 at 03:13:51PM +0800, Peter Chen wrote: > > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: > > > > > I am afraid I still not find the user (udc driver) for this framework, > > > > I would > > > > like

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-29 Thread Mark Brown
On Mon, Mar 28, 2016 at 03:13:51PM +0800, Peter Chen wrote: > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: > > > I am afraid I still not find the user (udc driver) for this framework, I > > > would > > > like to see how udc driver block the enumeration until the charger > > > det

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-29 Thread Mark Brown
On Tue, Mar 29, 2016 at 10:05:23AM +0800, Baolin Wang wrote: > Yes, The user 'wm831x_power' did not implement any callbacks in > 'usb_charger_detect_type()' function, but in > 'usb_charger_detect_type()' function it just supplies different > callbacks to get the charger type with simple logic. Any

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-29 Thread Baolin Wang
>> Linux PM list ; USB ; >> device-mainlin...@lists.linuxfoundation.org; LKML > ker...@vger.kernel.org> >> Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with >> the usb gadget power negotation >> >> On 25 March 2016 at 15:09, Peter Chen

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-29 Thread Jun Li
> > Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with > the usb gadget power negotation > > On 25 March 2016 at 15:09, Peter Chen wrote: > > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: > >> Currently the Linux kernel does not pr

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-28 Thread Baolin Wang
On 29 March 2016 at 08:32, Peter Chen wrote: > >> >> On 28 March 2016 at 15:13, Peter Chen wrote: >> > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: >> >> On 25 March 2016 at 15:09, Peter Chen wrote: >> >> > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: >> >> >> Cur

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-28 Thread Peter Chen
> > On 28 March 2016 at 15:13, Peter Chen wrote: > > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: > >> On 25 March 2016 at 15:09, Peter Chen wrote: > >> > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: > >> >> Currently the Linux kernel does not provide any standa

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-28 Thread Baolin Wang
On 28 March 2016 at 15:13, Peter Chen wrote: > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: >> On 25 March 2016 at 15:09, Peter Chen wrote: >> > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: >> >> Currently the Linux kernel does not provide any standard integration

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-28 Thread Peter Chen
On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: > On 25 March 2016 at 15:09, Peter Chen wrote: > > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: > >> Currently the Linux kernel does not provide any standard integration of > >> this > >> feature that integrates the USB

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-27 Thread Baolin Wang
On 25 March 2016 at 15:09, Peter Chen wrote: > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >> provided by PMICs meaning tha

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-25 Thread Peter Chen
On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels > o