Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Baolin Wang
On 7 April 2016 at 12:56, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: >> On Wed, Apr 06, 2016 at 01:25:06PM +0300, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Peter Chen writes: >>> > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: >>> >> Peter Chen writes: >>> >> > On Wed, Apr

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Felipe Balbi
Hi, Peter Chen writes: > On Wed, Apr 06, 2016 at 01:25:06PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Peter Chen writes: >> > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: >> >> Peter Chen writes: >> >> > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: >> >> >>

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Peter Chen
On Wed, Apr 06, 2016 at 01:25:06PM +0300, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: > >> Peter Chen writes: > >> > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: > >> >> Peter Chen writes: > >> >> > On Fr

RE: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Jun Li
@lists.linuxfoundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework > > On 6 April 2016 at 16:26, Jun Li wrote: > > Hi > > > >> + */ > >> +static enum usb_charger_type > >> +usb_cha

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Baolin Wang
On 6 April 2016 at 16:26, Jun Li wrote: > Hi > >> + */ >> +static enum usb_charger_type >> +usb_charger_get_type_by_others(struct usb_charger *uchger) { >> + if (uchger->type != UNKNOWN_TYPE) >> + return uchger->type; >> + >> + if (uchger->psy) { >> + union power_su

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Felipe Balbi
Hi, Peter Chen writes: > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: >> Peter Chen writes: >> > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: >> >> Peter Chen writes: >> >> > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: >> >> > + >> >> >> +sta

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Felipe Balbi
Hi, Peter Chen writes: > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: >> Peter Chen writes: >> > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: >> >> Peter Chen writes: >> >> > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: >> >> > + >> >> >> +sta

RE: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Jun Li
Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Baolin Wang > Sent: Friday, April 01, 2016 3:22 PM > To: ba...@kernel.org; gre...@linuxfoundation.org; s...@kernel.org; > dbarysh...@gmail.com; dw...@infradead.org > Cc:

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Peter Chen
On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: > Peter Chen writes: > > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: > >> Peter Chen writes: > >> > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > >> > + > >> >> +static struct attribute *usb_charger_

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Peter Chen
On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: > Peter Chen writes: > > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: > >> Peter Chen writes: > >> > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > >> > + > >> >> +static struct attribute *usb_charger_

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Felipe Balbi
Peter Chen writes: > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: >> Peter Chen writes: >> > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: >> > + >> >> +static struct attribute *usb_charger_attrs[] = { >> >> + &dev_attr_sdp_current.attr, >> >> + &dev_attr_dcp_curr

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Peter Chen
On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: > Peter Chen writes: > > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > > + > >> +static struct attribute *usb_charger_attrs[] = { > >> + &dev_attr_sdp_current.attr, > >> + &dev_attr_dcp_current.attr, > >> + &dev_att

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Felipe Balbi
Peter Chen writes: > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > + >> +static struct attribute *usb_charger_attrs[] = { >> +&dev_attr_sdp_current.attr, >> +&dev_attr_dcp_current.attr, >> +&dev_attr_cdp_current.attr, >> +&dev_attr_aca_current.attr, >> +&dev_a

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-06 Thread Peter Chen
On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: + > +static struct attribute *usb_charger_attrs[] = { > + &dev_attr_sdp_current.attr, > + &dev_attr_dcp_current.attr, > + &dev_attr_cdp_current.attr, > + &dev_attr_aca_current.attr, > + &dev_attr_charger_type.attr, >

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-05 Thread Baolin Wang
On 5 April 2016 at 15:56, Peter Chen wrote: > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: >> + >> +int devm_usb_charger_register(struct device *dev, >> + struct usb_charger *uchger) >> +{ >> + struct usb_charger **ptr; >> + int ret; >> + >> +

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

2016-04-05 Thread Peter Chen
On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > + > +int devm_usb_charger_register(struct device *dev, > + struct usb_charger *uchger) > +{ > + struct usb_charger **ptr; > + int ret; > + > + ptr = devres_alloc(devm_uchger_dev_unreg, sizeof(*ptr),