Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-19 Thread Rusty Russell
Sjur Brændeland writes: >> Sjur Brændeland writes: >>> How about supporting struct vringh_kiov and struct kvec as well? >>> I currently get the following complaints with my V2 patch-set: >>> >>> drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of >>> ‘vringh_iov_init’ from incom

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-16 Thread Sjur Brændeland
> Sjur Brændeland writes: >> How about supporting struct vringh_kiov and struct kvec as well? >> I currently get the following complaints with my V2 patch-set: >> >> drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of >> ‘vringh_iov_init’ from incompatible pointer type [enabled by

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-15 Thread Rusty Russell
Sjur Brændeland writes: > How about supporting struct vringh_kiov and struct kvec as well? > I currently get the following complaints with my V2 patch-set: > > drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of > ‘vringh_iov_init’ from incompatible pointer type [enabled by defaul

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-13 Thread Sjur Brændeland
Hi Rusty, On Wed, Feb 13, 2013 at 11:16 AM, Rusty Russell wrote: > Sjur BRENDELAND writes: >>> > +static inline void ctx_prep_iov(struct cfv_napi_context *ctx) >>> > +{ >>> > + if (ctx->riov.allocated) { >>> > + kfree(ctx->riov.iov); >>> > + ctx->riov.iov = NULL; >>> > +

RE: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-13 Thread Rusty Russell
Sjur BRENDELAND writes: > Hi Rusty, > >> From: Rusty Russell [mailto:ru...@rustcorp.com.au] >> sjur.brandel...@stericsson.com writes: >> > +struct cfv_napi_context { >> > + struct vringh_kiov riov; >> > + unsigned short head; >> > +}; >> >> Usually we use an int, and -1. I imagine it'll take n

RE: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-11 Thread Sjur BRENDELAND
Hi Rusty, > From: Rusty Russell [mailto:ru...@rustcorp.com.au] > sjur.brandel...@stericsson.com writes: > > From: Vikram ARV > > > > Add the the Virtio shared memory driver for STE Modems. > > caif_virtio is implemented utilizing the virtio framework > > for data transport and is managed with the

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-10 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Vikram ARV > > Add the the Virtio shared memory driver for STE Modems. > caif_virtio is implemented utilizing the virtio framework > for data transport and is managed with the remoteproc frameworks. > > The Virtio queue is used for transmitting data t