> Subject: Re: [PATCHv1] ASoC: SGTL5000: Fix kernel failed while getting
> regulator consumers
>
> On Wed, Nov 27, 2013 at 08:13:03AM +, Li Xiubo wrote:
>
> Please fix your mailer to word wrap within paragraphs, it makes your mail
> much more legible.
>
Yes, I
On Wed, Nov 27, 2013 at 08:13:03AM +, Li Xiubo wrote:
Please fix your mailer to word wrap within paragraphs, it makes your
mail much more legible.
> There is one dependency patch: "regulator: core: Provide a dummy regulator
> with full constraints".
> From the dependency patch, we can see
> > +static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec)
> > +{
> > + struct regulator *consumer;
> > + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec);
> > +
> > + consumer = regulator_get(codec->dev, sgtl5000-
> >supplies[VDDD].supply);
> > + if
+static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec)
+{
+ struct regulator *consumer;
+ struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec);
+
+ consumer = regulator_get(codec-dev, sgtl5000-
supplies[VDDD].supply);
+ if (IS_ERR(consumer)) {
+
On Wed, Nov 27, 2013 at 08:13:03AM +, Li Xiubo wrote:
Please fix your mailer to word wrap within paragraphs, it makes your
mail much more legible.
There is one dependency patch: regulator: core: Provide a dummy regulator
with full constraints.
From the dependency patch, we can see that
Subject: Re: [PATCHv1] ASoC: SGTL5000: Fix kernel failed while getting
regulator consumers
On Wed, Nov 27, 2013 at 08:13:03AM +, Li Xiubo wrote:
Please fix your mailer to word wrap within paragraphs, it makes your mail
much more legible.
Yes, I will.
There is one dependency
> > else {
> > ret = sgtl5000_replace_vddd_with_ldo(codec);
> >
> You could fix the coding style issue (braces on both branches of the if
> clause) here too.
>
>
Yes, I will.
Thanks.
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z�
On Tue, Nov 26, 2013 at 05:55:13PM +0800, Xiubo Li wrote:
> +static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec)
> +{
> + struct regulator *consumer;
> + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec);
> +
> + consumer = regulator_get(codec->dev,
Hi,
Xiubo Li wrote:
> SGTL5000 codec allows to use the internal LDO instead of VDDD, if the
> internal LDO is used, this caused the following kernel failed while trying
> to get the external VDDD regulator consumer.
>
> Adding sgtl5000_external_vddd_used() to fix it. And this has been tested on
Hi,
Xiubo Li wrote:
SGTL5000 codec allows to use the internal LDO instead of VDDD, if the
internal LDO is used, this caused the following kernel failed while trying
to get the external VDDD regulator consumer.
Adding sgtl5000_external_vddd_used() to fix it. And this has been tested on
On Tue, Nov 26, 2013 at 05:55:13PM +0800, Xiubo Li wrote:
+static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec)
+{
+ struct regulator *consumer;
+ struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec);
+
+ consumer = regulator_get(codec-dev,
else {
ret = sgtl5000_replace_vddd_with_ldo(codec);
You could fix the coding style issue (braces on both branches of the if
clause) here too.
Yes, I will.
Thanks.
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z�
12 matches
Mail list logo
