RE: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver

2012-08-09 Thread Arun MURTHY
> > Basically it doesn't suit our protocol of having base addr, read/write > > pointer, locking etc as the same set of structures and protocol will > > be used on the modem side implementation. > > Ok. What happens about endianness or is the modem always the same > endianness as the host ? Yes it

Re: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver

2012-08-08 Thread Alan Cox
> Basically it doesn't suit our protocol of having base addr, read/write > pointer, locking etc as the same set of structures and protocol will be > used on the modem side implementation. Ok. What happens about endianness or is the modem always the same endianness as the host ? > > > + if (len

RE: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver

2012-08-07 Thread Arun MURTHY
> > drivers/modem_shm/Kconfig|2 + > > drivers/modem_shm/Makefile |1 + > > drivers/modem_shm/u8500_shm/Kconfig | 43 + > > drivers/modem_shm/u8500_shm/Makefile |7 + > > drivers/modem_shm/u8500_shm/shrm_char.c

RE: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver

2012-08-07 Thread Arun MURTHY
> > +#define SIZE_OF_FIFO (512*1024) > > + > > +static u8 message_fifo[ISA_DEVICES][SIZE_OF_FIFO]; > > Thats a huge amount of static memory that gets allocated regardless of > whether the device is open or being used ? Yes, but all of these will be used, in any system which includes APE-Modem comm

Re: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver

2012-08-07 Thread Greg KH
On Tue, Aug 07, 2012 at 12:24:30PM +0530, Arun Murthy wrote: > The communication between APE and CMT in u8500 is by means of a shared DDR. > Since its a shared memory, this driver implements shrm protocol. > > Signed-off-by: Arun Murthy > Acked-by: Linus Walleij > --- > drivers/modem_shm/Kconfi

Re: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver

2012-08-07 Thread Alan Cox
> +#define SIZE_OF_FIFO (512*1024) > + > +static u8 message_fifo[ISA_DEVICES][SIZE_OF_FIFO]; Thats a huge amount of static memory that gets allocated regardless of whether the device is open or being used ? > +static int major; > +module_param(major, int, 0); > +MODULE_PARM_DESC(major, "Major dev