RE: [PATCHv5] procfs: show hierarchy of pid namespace

2014-11-04 Thread Chen, Hanxiao
teusz Guzik; David > Howells; > Eric W. Biederman > Subject: Re: [PATCHv5] procfs: show hierarchy of pid namespace > > If pidns_list_add fails, the get_pid taken in the caller leaks. > Will fix in the next patch. > It's not clear to me that the loop in 'if curns

Re: [PATCHv5] procfs: show hierarchy of pid namespace

2014-10-31 Thread serge
If pidns_list_add fails, the get_pid taken in the caller leaks. It's not clear to me that the loop in 'if curns' will always end in a list_add_tail, and if not the get_pid leaks. It does look like it should, but something to catch the unexpected failure (especially after someone modifies that

RE: [PATCHv5] procfs: show hierarchy of pid namespace

2014-10-21 Thread Chen, Hanxiao
> -Original Message- > From: containers-boun...@lists.linux-foundation.org > [mailto:containers-boun...@lists.linux-foundation.org] On Behalf Of Chen > Hanxiao > Sent: Thursday, October 16, 2014 8:02 PM > To: contain...@lists.linux-foundation.org; linux-kernel@vger.kernel.org > Cc: Richar