Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Dinh Nguyen
On 10/23/2014 01:28 PM, Paul Zimmerman wrote: >> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] >> Sent: Wednesday, October 22, 2014 5:26 AM >> >> On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote: >>> From: Dinh Nguyen >>> >>> config USB_DWC2_PLATFOR

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Wednesday, October 22, 2014 5:26 AM > > On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > config USB_DWC2_PLATFORM > > bool "DWC2 Platform" > > - depends on

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Paul Bolle
On Thu, 2014-10-23 at 10:05 -0500, Dinh Nguyen wrote: > On 10/22/2014 03:27 PM, Paul Bolle wrote: > > On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote: > Well, CONFIG_USB enables the host stack that is needed by the DWC2 > driver, without CONFIG_USB, the DWC2 driver will not be able to build. >

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Dinh Nguyen
On 10/22/2014 03:27 PM, Paul Bolle wrote: > On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote: >> On 10/20/2014 02:42 PM, Paul Bolle wrote: >>> (Side note: drivers/usb/dwc2/Kconfig is sourced (in drivers/usb/Kconfig) >>> even if USB is _not_ set. But USB_DCW2 still depends on USB. Why is >>> tha

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Paul Bolle
On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote: > On 10/20/2014 02:42 PM, Paul Bolle wrote: > > (Side note: drivers/usb/dwc2/Kconfig is sourced (in drivers/usb/Kconfig) > > even if USB is _not_ set. But USB_DCW2 still depends on USB. Why is > > that?) > > Because USB is for Host-Side support

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 21, 2014 1:48 PM > > diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig > index f93807b..1ea702e 100644 > --- a/drivers/usb/dwc2/Kconfig > +++ b/drivers/usb/dwc2/Kconfig > @@ -1,5 +1,5 @@ > config US

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Bartlomiej Zolnierkiewicz
On Wednesday, October 22, 2014 02:25:46 PM Bartlomiej Zolnierkiewicz wrote: > BTW It is a bit late but it would be great if you could split your > patchset on two. First one merging gadget functionality into > core/platform code and the second one adding USB_DWC2_DUAL_ROLE > functionality. On th

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > Update DWC2 kconfig and makefile to support dual-role mode. The platform > file will always get compiled for the case where the controller is directly > connected to the CPU. So for loadabl

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-21 Thread Dinh Nguyen
On 10/20/2014 02:42 PM, Paul Bolle wrote: > dingu...@opensource.altera.com schreef op ma 20-10-2014 om 13:52 > [-0500]: >> From: Dinh Nguyen >> >> Update DWC2 kconfig and makefile to support dual-role mode. The platform >> file will always get compiled for the case where the controller is directly

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-20 Thread Paul Bolle
dingu...@opensource.altera.com schreef op ma 20-10-2014 om 13:52 [-0500]: > From: Dinh Nguyen > > Update DWC2 kconfig and makefile to support dual-role mode. The platform > file will always get compiled for the case where the controller is directly > connected to the CPU. So for loadable modules,