> On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
> > On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
> > > I fail to see how that would eliminate the problem with the types.
> > > That said I don't actually see sparse complaining about any type
> mismatches.
> > >
On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
I fail to see how that would eliminate the problem with the types.
That said I don't actually see sparse complaining about any type
mismatches.
That's probably
> On Tue, Dec 17, 2013 at 01:00:10PM +0100, Tomasz Figa wrote:
> > On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
> > > On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
> > > > On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
> > > > > +static
On Tue, Dec 17, 2013 at 01:04:35PM +, Russell King - ARM Linux wrote:
> On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
> > On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
> > > I fail to see how that would eliminate the problem with the types. That
> > > said I
On Tue, Dec 17, 2013 at 12:58:32PM +, Russell King - ARM Linux wrote:
> On Tue, Dec 17, 2013 at 01:24:33PM +0100, Thierry Reding wrote:
> > On Tue, Dec 17, 2013 at 11:51:36AM +, Russell King - ARM Linux wrote:
> > > Same comments here - what memory operations is the wmb() trying to
> > >
On Tuesday 17 of December 2013 13:04:35 Russell King - ARM Linux wrote:
> On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
> > On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
> > > I fail to see how that would eliminate the problem with the types. That
> > > said I don't
On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
> On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
> > I fail to see how that would eliminate the problem with the types. That
> > said I don't actually see sparse complaining about any type mismatches.
> > That's probably
On Tue, Dec 17, 2013 at 01:24:33PM +0100, Thierry Reding wrote:
> On Tue, Dec 17, 2013 at 11:51:36AM +, Russell King - ARM Linux wrote:
> > Same comments here - what memory operations is the wmb() trying to
> > serialise? Does this PWM driver somehow end up doing DMA?
>
> Not that I can see.
On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
> On Tue, Dec 17, 2013 at 01:00:10PM +0100, Tomasz Figa wrote:
> > On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
> > > On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
> > > > On Fri, Dec 13,
On Tue, Dec 17, 2013 at 01:00:10PM +0100, Tomasz Figa wrote:
> On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
> > On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
> > > On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
> > > > +static inline u32
On Tue, Dec 17, 2013 at 11:51:36AM +, Russell King - ARM Linux wrote:
> On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
> > On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
> > > +static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
> > > + const void
On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
> On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
> > On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
> > > +static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
> > > + const void
On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
> On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
> > +static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
> > + const void __iomem *addr)
> > +{
> > + u32 val;
> > +
> > + val = __raw_readl(addr);
> > +
On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
[...]
> diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile
> index 8b754e4..9029a12 100644
> --- a/drivers/pwm/Makefile
> +++ b/drivers/pwm/Makefile
> @@ -5,6 +5,7 @@ obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o
>
On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
[...]
diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile
index 8b754e4..9029a12 100644
--- a/drivers/pwm/Makefile
+++ b/drivers/pwm/Makefile
@@ -5,6 +5,7 @@ obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o
On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
+static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
+ const void __iomem *addr)
+{
+ u32 val;
+
+ val = __raw_readl(addr);
+
+ if
On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
+static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
+ const void __iomem *addr)
On Tue, Dec 17, 2013 at 11:51:36AM +, Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
+static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
+ const void __iomem
On Tue, Dec 17, 2013 at 01:00:10PM +0100, Tomasz Figa wrote:
On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
+static inline u32
On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
On Tue, Dec 17, 2013 at 01:00:10PM +0100, Tomasz Figa wrote:
On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
On Fri, Dec 13, 2013 at
On Tue, Dec 17, 2013 at 01:24:33PM +0100, Thierry Reding wrote:
On Tue, Dec 17, 2013 at 11:51:36AM +, Russell King - ARM Linux wrote:
Same comments here - what memory operations is the wmb() trying to
serialise? Does this PWM driver somehow end up doing DMA?
Not that I can see. But if
On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
I fail to see how that would eliminate the problem with the types. That
said I don't actually see sparse complaining about any type mismatches.
That's probably because
On Tuesday 17 of December 2013 13:04:35 Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
I fail to see how that would eliminate the problem with the types. That
said I don't actually
On Tue, Dec 17, 2013 at 12:58:32PM +, Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 01:24:33PM +0100, Thierry Reding wrote:
On Tue, Dec 17, 2013 at 11:51:36AM +, Russell King - ARM Linux wrote:
Same comments here - what memory operations is the wmb() trying to
serialise?
On Tue, Dec 17, 2013 at 01:04:35PM +, Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote:
On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote:
I fail to see how that would eliminate the problem with the types. That
said I don't
On Tue, Dec 17, 2013 at 01:00:10PM +0100, Tomasz Figa wrote:
On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote:
On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote:
On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote:
+static inline u32
26 matches
Mail list logo