Re: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-21 Thread Luis R. Rodriguez
On Tue, Feb 21, 2017 at 09:17:15PM +0100, Luis R. Rodriguez wrote: > On Tue, Feb 21, 2017 at 07:15:41PM +0100, Luis R. Rodriguez wrote: > > On Tue, Feb 21, 2017 at 07:16:16AM +, Grumbach, Emmanuel wrote: > > > > > > > > a) just remove the print and use instead request_module_nowait() (this >

Re: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-21 Thread Luis R. Rodriguez
On Tue, Feb 21, 2017 at 07:15:41PM +0100, Luis R. Rodriguez wrote: > On Tue, Feb 21, 2017 at 07:16:16AM +, Grumbach, Emmanuel wrote: > > > > > > a) just remove the print and use instead request_module_nowait() (this is > > > more in alignment of what your code actually does today; or > > > >

Re: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-21 Thread Luis R. Rodriguez
On Tue, Feb 21, 2017 at 07:16:16AM +, Grumbach, Emmanuel wrote: > > > > a) just remove the print and use instead request_module_nowait() (this is > > more in alignment of what your code actually does today; or > > > > b) fix the request_module() use so that the error print matches the > > exp

RE: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-20 Thread Grumbach, Emmanuel
> > On Sun, Feb 19, 2017 at 09:47:59AM +, Grumbach, Emmanuel wrote: > > > > > > The return value of request_module() being 0 does not mean that the > > > driver which was requested has loaded. To properly check that the > > > driver was loaded each driver can use internal mechanisms to vet the

Re: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-20 Thread Luis R. Rodriguez
On Sun, Feb 19, 2017 at 09:47:59AM +, Grumbach, Emmanuel wrote: > > > > The return value of request_module() being 0 does not mean that the driver > > which was requested has loaded. To properly check that the driver was > > loaded each driver can use internal mechanisms to vet the driver is n

RE: [RFC 2/5] iwlwifi: fix request_module() use

2017-02-19 Thread Grumbach, Emmanuel
> > The return value of request_module() being 0 does not mean that the driver > which was requested has loaded. To properly check that the driver was > loaded each driver can use internal mechanisms to vet the driver is now > present. The helper try_then_request_module() was added to help with >