Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-12 Thread Fenghua Yu
On Wed, Jun 12, 2019 at 05:59:08AM +0200, Borislav Petkov wrote: > On Wed, Jun 12, 2019 at 03:29:57AM +, Yu, Fenghua wrote: > > My bad. I studied a bit more and found the patch #1 is not needed. > > Why, I think you were spot-on: > > "And the two variables are ONLY used in resctrl monitoring

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-12 Thread Fenghua Yu
On Wed, Jun 12, 2019 at 07:10:49AM -0700, Sean Christopherson wrote: > On Wed, Jun 12, 2019 at 06:02:59AM +0200, Borislav Petkov wrote: > > On Tue, Jun 11, 2019 at 08:32:59PM -0700, Fenghua Yu wrote: > > > Currently KVM doesn't simulate scattered features (the ones in CPUID_LNX_* > > > in

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-12 Thread Sean Christopherson
On Wed, Jun 12, 2019 at 06:02:59AM +0200, Borislav Petkov wrote: > On Tue, Jun 11, 2019 at 08:32:59PM -0700, Fenghua Yu wrote: > > Currently KVM doesn't simulate scattered features (the ones in CPUID_LNX_* > > in cpuid_leafs) as reverse_cpuid[] doesn't contain CPUID_LNX_*. > > 43500e6f294d

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-11 Thread Borislav Petkov
On Tue, Jun 11, 2019 at 08:32:59PM -0700, Fenghua Yu wrote: > Currently KVM doesn't simulate scattered features (the ones in CPUID_LNX_* > in cpuid_leafs) as reverse_cpuid[] doesn't contain CPUID_LNX_*. 43500e6f294d ("x86/cpufeatures: Remove get_scattered_cpuid_leaf()") > After the

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-11 Thread Borislav Petkov
On Wed, Jun 12, 2019 at 03:29:57AM +, Yu, Fenghua wrote: > My bad. I studied a bit more and found the patch #1 is not needed. Why, I think you were spot-on: "And the two variables are ONLY used in resctrl monitoring configuration. There is no need to store them in cpuinfo_x86 on each CPU."

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-11 Thread Fenghua Yu
On Tue, Jun 11, 2019 at 09:47:02PM +0200, Borislav Petkov wrote: > On Tue, Jun 11, 2019 at 11:19:20AM -0700, Fenghua Yu wrote: > > So can I re-organize word 11 and 12 as follows? > > > > 1. Change word 11 to host scattered features. > > 2. Move the previos features in word 11 and word 12 to word

RE: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-11 Thread Yu, Fenghua
> On Tuesday, June 11, 2019 3:28 PM, Fenghua Yu wrote: > On Tue, Jun 11, 2019 at 09:47:02PM +0200, Borislav Petkov wrote: > > On Tue, Jun 11, 2019 at 11:19:20AM -0700, Fenghua Yu wrote: > > > So can I re-organize word 11 and 12 as follows? > > > > > > 1. Change word 11 to host scattered features.

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-11 Thread Fenghua Yu
On Tue, Jun 11, 2019 at 09:47:02PM +0200, Borislav Petkov wrote: > On Tue, Jun 11, 2019 at 11:19:20AM -0700, Fenghua Yu wrote: > > So can I re-organize word 11 and 12 as follows? > > > > 1. Change word 11 to host scattered features. > > 2. Move the previos features in word 11 and word 12 to word

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-11 Thread Borislav Petkov
On Tue, Jun 11, 2019 at 11:19:20AM -0700, Fenghua Yu wrote: > So can I re-organize word 11 and 12 as follows? > > 1. Change word 11 to host scattered features. > 2. Move the previos features in word 11 and word 12 to word 11: > /* > * Extended auxiliary flags: Linux defined - For features

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-11 Thread Fenghua Yu
On Mon, Jun 10, 2019 at 09:20:26PM +0200, Borislav Petkov wrote: > On Mon, Jun 10, 2019 at 10:02:38AM -0700, Fenghua Yu wrote: > > AVX512 Vector Neural Network Instructions (VNNI) in Intel Deep Learning > > Boost support bfloat16 format (BF16). BF16 is a short version of FP32 and > > has several

Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

2019-06-10 Thread Borislav Petkov
On Mon, Jun 10, 2019 at 10:02:38AM -0700, Fenghua Yu wrote: > AVX512 Vector Neural Network Instructions (VNNI) in Intel Deep Learning > Boost support bfloat16 format (BF16). BF16 is a short version of FP32 and > has several advantages over FP16. BF16 offers more than enough range for > deep