RE: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-04 Thread Winkler, Tomas
> On Thu, Mar 4, 2021 at 8:54 PM Winkler, Tomas > wrote: > > > Winkler, Tomas writes: > > > >> "Winkler, Tomas" writes: > > > >> > > > >> >> The user space API is achieved via a number of synchronous > IOCTLs. > > > >> >> > > > >> >> * RPMB_IOC_VER_CMD - simple versioning API > > > >> >> * R

Re: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-04 Thread Arnd Bergmann
On Thu, Mar 4, 2021 at 8:54 PM Winkler, Tomas wrote: > > Winkler, Tomas writes: > > >> "Winkler, Tomas" writes: > > >> > > >> >> The user space API is achieved via a number of synchronous IOCTLs. > > >> >> > > >> >> * RPMB_IOC_VER_CMD - simple versioning API > > >> >> * RPMB_IOC_CAP_CMD - qu

Re: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-04 Thread Arnd Bergmann
On Wed, Mar 3, 2021 at 2:54 PM Alex Bennée wrote: > > + /* the rpmb is single open! */ > + if (test_and_set_bit(RPMB_DEV_OPEN, &rdev->status)) > + return -EBUSY; open counters on device nodes are fundamentally broken, because they do not stop you from using dup() or shar

RE: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-04 Thread Winkler, Tomas
> > Winkler, Tomas writes: > > >> "Winkler, Tomas" writes: > >> > >> >> The user space API is achieved via a number of synchronous IOCTLs. > >> >> > >> >> * RPMB_IOC_VER_CMD - simple versioning API > >> >> * RPMB_IOC_CAP_CMD - query of underlying capabilities > >> >> * RPMB_IOC_PKEY_CMD

Re: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-04 Thread Alex Bennée
Winkler, Tomas writes: >> "Winkler, Tomas" writes: >> >> >> The user space API is achieved via a number of synchronous IOCTLs. >> >> >> >> * RPMB_IOC_VER_CMD - simple versioning API >> >> * RPMB_IOC_CAP_CMD - query of underlying capabilities >> >> * RPMB_IOC_PKEY_CMD - one time programm

RE: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-04 Thread Winkler, Tomas
> "Winkler, Tomas" writes: > > >> The user space API is achieved via a number of synchronous IOCTLs. > >> > >> * RPMB_IOC_VER_CMD - simple versioning API > >> * RPMB_IOC_CAP_CMD - query of underlying capabilities > >> * RPMB_IOC_PKEY_CMD - one time programming of access key > >> * RPMB_I

Re: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-04 Thread Alex Bennée
"Winkler, Tomas" writes: >> The user space API is achieved via a number of synchronous IOCTLs. >> >> * RPMB_IOC_VER_CMD - simple versioning API >> * RPMB_IOC_CAP_CMD - query of underlying capabilities >> * RPMB_IOC_PKEY_CMD - one time programming of access key >> * RPMB_IOC_COUNTER_CMD -

RE: [RFC PATCH 2/5] char: rpmb: provide a user space interface

2021-03-03 Thread Winkler, Tomas
> > The user space API is achieved via a number of synchronous IOCTLs. > > * RPMB_IOC_VER_CMD - simple versioning API > * RPMB_IOC_CAP_CMD - query of underlying capabilities > * RPMB_IOC_PKEY_CMD - one time programming of access key > * RPMB_IOC_COUNTER_CMD - query the write counter >