Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-24 Thread Arnd Bergmann
On Wednesday 23 April 2014, Liviu Dudau wrote: > On Wed, Apr 23, 2014 at 10:19:30AM +0100, Kukjin Kim wrote: > > Arnd Bergmann wrote: > > > > > > Can you explain how much the GH7 and Exynos front-ends actually have in > > > common? Would it make sense to have a separate driver for gh7? > > > > >

Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-24 Thread Arnd Bergmann
On Thursday 24 April 2014 13:53:47 Kukjin Kim wrote: > Arnd Bergmann wrote: > > > > On Wednesday 23 April 2014 15:23:16 Liviu Dudau wrote: > > > > Unfortunately we are in a tricky situation on arm64 because we have > > > > to support both server-type SoCs and embedded-type SoCs. In an > > > > embe

RE: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-23 Thread Kukjin Kim
Arnd Bergmann wrote: > > On Wednesday 23 April 2014 15:23:16 Liviu Dudau wrote: > > > Unfortunately we are in a tricky situation on arm64 because we have > > > to support both server-type SoCs and embedded-type SoCs. In an > > > embedded system, you can't trust the boot loader to do a proper > > >

Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-23 Thread Arnd Bergmann
On Wednesday 23 April 2014 15:23:16 Liviu Dudau wrote: > > Unfortunately we are in a tricky situation on arm64 because we have > > to support both server-type SoCs and embedded-type SoCs. In an > > embedded system, you can't trust the boot loader to do a proper > > setup of all the hardware, so the

Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-23 Thread Liviu Dudau
On Wed, Apr 23, 2014 at 12:03:47PM +0100, Arnd Bergmann wrote: > On Wednesday 23 April 2014 18:19:30 Kukjin Kim wrote: > > > > > Basically, ARMv8 based GH7 has same PCIe hardware IP with previous ARMv7 > > based exynos5440, several features in PCIe are different though. In other > > words, basic

Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-23 Thread Liviu Dudau
On Wed, Apr 23, 2014 at 10:19:30AM +0100, Kukjin Kim wrote: > Arnd Bergmann wrote: > > > > On Wednesday 16 April 2014, Jingoo Han wrote: > > > Samsung GH7 has four PCIe controllers which can be used as root > > > complex for PCIe interface. > > > > > > Signed-off-by: Jingoo Han > > > --- > > > d

Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-23 Thread Arnd Bergmann
On Wednesday 23 April 2014 18:19:30 Kukjin Kim wrote: > > Basically, ARMv8 based GH7 has same PCIe hardware IP with previous ARMv7 > based exynos5440, several features in PCIe are different though. In other > words, basic functionalities for PCIe are same. So I think, would be nice if > we could

RE: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-23 Thread Kukjin Kim
Arnd Bergmann wrote: > > On Wednesday 16 April 2014, Jingoo Han wrote: > > Samsung GH7 has four PCIe controllers which can be used as root > > complex for PCIe interface. > > > > Signed-off-by: Jingoo Han > > --- > > drivers/pci/host/Kconfig |2 +- > > drivers/pci/host/pci-exynos.c | 1

Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC

2014-04-22 Thread Arnd Bergmann
On Wednesday 16 April 2014, Jingoo Han wrote: > Samsung GH7 has four PCIe controllers which can be used as root > complex for PCIe interface. > > Signed-off-by: Jingoo Han > --- > drivers/pci/host/Kconfig |2 +- > drivers/pci/host/pci-exynos.c | 135 > +