RE: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2013-05-09 Thread Guennadi Liakhovetski
i Liakhovetski [mailto:g.liakhovet...@gmx.de] > > Sent: 09 May 2013 15:29 > > To: Anthony Olech > > Cc: Krystian Garbaciak; Mark Brown; linux-kernel@vger.kernel.org; Samuel > > Ortiz; Alessandro Zummo; Jean Delvare; Dmitry Torokhov; Richard Purdie > > Subject: RE: [RFC PATC

RE: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2013-05-09 Thread Anthony Olech
t; Cc: Krystian Garbaciak; Mark Brown; linux-kernel@vger.kernel.org; Samuel > Ortiz; Alessandro Zummo; Jean Delvare; Dmitry Torokhov; Richard Purdie > Subject: RE: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators > support. > > Hi Tony > > On Thu, 9 May

RE: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2013-05-09 Thread Guennadi Liakhovetski
May 2013 15:06 > > To: Krystian Garbaciak > > Cc: Mark Brown; linux-kernel@vger.kernel.org; Samuel Ortiz; Alessandro > > Zummo; Jean Delvare; Dmitry Torokhov; Richard Purdie; Anthony Olech > > Subject: Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators >

RE: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2013-05-09 Thread Anthony Olech
ummo; Jean Delvare; Dmitry Torokhov; Richard Purdie; Anthony Olech > Subject: Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators > support. > > (trimmed the CC a bit) > > Hi Krystian > > On Fri, 31 Aug 2012, Krystian Garbaciak wrote: > > > > On Wed

Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2013-05-09 Thread Guennadi Liakhovetski
(trimmed the CC a bit) Hi Krystian On Fri, 31 Aug 2012, Krystian Garbaciak wrote: > > On Wed, Aug 29, 2012 at 03:50:00PM +0100, Krystian Garbaciak wrote: Sorry for picking up a random mail from this old thread, unfortunately, I don't have "0/8" in my archive. I have to write a driver for the

Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2012-08-31 Thread Krystian Garbaciak
> On Wed, Aug 29, 2012 at 03:50:00PM +0100, Krystian Garbaciak wrote: > > > Because, for some regulators, this is required: val += fvol->offset, > > I was only able to reduce it to the following form. > > What on earth makes you say this? The above is obviously linear. > > Besides, you're missi

Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2012-08-30 Thread Mark Brown
On Wed, Aug 29, 2012 at 03:50:00PM +0100, Krystian Garbaciak wrote: > Because, for some regulators, this is required: val += fvol->offset, > I was only able to reduce it to the following form. What on earth makes you say this? The above is obviously linear. Besides, you're missing several point

Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2012-08-29 Thread Krystian Garbaciak
> > +static int da906x_set_voltage(struct regulator_dev *rdev, > > + int min_uV, int max_uV, unsigned *selector) > > +{ > > + struct da906x_regulator *regl = rdev_get_drvdata(rdev); > > + const struct field *fvol = ®l->info->voltage; > > + int ret; > > + unsigned v

Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

2012-08-25 Thread Mark Brown
On Fri, Aug 24, 2012 at 02:55:00PM +0100, Krystian Garbaciak wrote: > +static int da906x_set_voltage(struct regulator_dev *rdev, > + int min_uV, int max_uV, unsigned *selector) > +{ > + struct da906x_regulator *regl = rdev_get_drvdata(rdev); > + const struct fie