RE: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-17 Thread Daejun Park
> > This patch is adding UFS feature layer to UFS core driver. > > > > UFS Driver data structure (struct ufs_hba) > > │ > > ┌--┐ > > │ UFS feature │ <-- HPB module > > │layer │ <-- other extended feature module > > └--┘ > > Each extended UFS-Feature module

Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-17 Thread Alim Akhtar
Hi Bean, On Wed, Jun 17, 2020 at 3:12 PM Bean Huo wrote: > > > > HPB1.0 isn't part of ufs3.1, but published only later. > > > Allowing earlier versions will required to quirk the descriptor > > > sizes. > > > I see Bean's point here, but I vote for adding it in a single > > > quirk, when the time

Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-17 Thread Bean Huo
On Wed, 2020-06-17 at 14:27 +0530, Alim Akhtar wrote: > > > > > + init_waitqueue_head(&hba->ufsf.sdev_wait); > > > > > + atomic_set(&hba->ufsf.slave_conf_cnt, 0); > > > > > + > > > > > + if (hba->dev_info.wspecversion >= > > > > > HPB_SUPPORTED_VERSION && > > > > > + (hb

Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-17 Thread Alim Akhtar
On Wed, Jun 17, 2020 at 12:27 PM Avri Altman wrote: > > > > > Hi, Bean > > > > > > On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote: > > > > +void ufsf_scan_features(struct ufs_hba *hba) > > > > +{ > > > > + int ret; > > > > + > > > > + init_waitqueue_head(&hba->ufsf.sdev_wait); >

RE: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-17 Thread Avri Altman
> > This patch is adding UFS feature layer to UFS core driver. > > UFS Driver data structure (struct ufs_hba) > │ > ┌--┐ > │ UFS feature │ <-- HPB module > │layer │ <-- other extended feature module > └--┘ > Each extended UFS-Feature module has a bus of

RE: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-16 Thread Avri Altman
> > Hi, Bean > > > > On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote: > > > +void ufsf_scan_features(struct ufs_hba *hba) > > > +{ > > > + int ret; > > > + > > > + init_waitqueue_head(&hba->ufsf.sdev_wait); > > > + atomic_set(&hba->ufsf.slave_conf_cnt, 0); > > > + > > > +

Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-15 Thread Daejun Park
Hi, Bean > > On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote: > > +void ufsf_scan_features(struct ufs_hba *hba) > > +{ > > + int ret; > > + > > + init_waitqueue_head(&hba->ufsf.sdev_wait); > > + atomic_set(&hba->ufsf.slave_conf_cnt, 0); > > + > > + if (hba->dev_info.ws

Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer

2020-06-15 Thread Bean Huo
Hi, Daejun On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote: > +void ufsf_scan_features(struct ufs_hba *hba) > +{ > + int ret; > + > + init_waitqueue_head(&hba->ufsf.sdev_wait); > + atomic_set(&hba->ufsf.slave_conf_cnt, 0); > + > + if (hba->dev_info.wspecversion >= HPB_