RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-18 Thread Daejun Park
> > > + > > > > +static struct ufshpb_map_ctx *ufshpb_get_map_ctx(struct ufshpb_lu > > *hpb) > > > > +{ > > > > + struct ufshpb_map_ctx *mctx; > > > > + int i, j; > > > > + > > > > + mctx = mempool_alloc(ufshpb_drv.ufshpb_mctx_pool, GFP_KERNEL); > > > > + if (!mctx) > > > >

RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-18 Thread Daejun Park
> +static void ufshpb_run_active_subregion_list(struct ufshpb_lu *hpb) > > +{ > > + struct ufshpb_region *rgn; > > + struct ufshpb_subregion *srgn; > > + struct ufshpb_map_ctx *mctx; > mctx doesn't really do anything here OK, I will delete it. > > + unsigned long flags;

RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-18 Thread Avri Altman
> +static void ufshpb_run_active_subregion_list(struct ufshpb_lu *hpb) > +{ > + struct ufshpb_region *rgn; > + struct ufshpb_subregion *srgn; > + struct ufshpb_map_ctx *mctx; mctx doesn't really do anything here > + unsigned long flags; > + int ret = 0; > + > +

RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-18 Thread Avri Altman
> > + > > > +static struct ufshpb_map_ctx *ufshpb_get_map_ctx(struct ufshpb_lu > *hpb) > > > +{ > > > + struct ufshpb_map_ctx *mctx; > > > + int i, j; > > > + > > > + mctx = mempool_alloc(ufshpb_drv.ufshpb_mctx_pool, GFP_KERNEL); > > > + if (!mctx) > > > +

RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-17 Thread Daejun Park
> + > > +static struct ufshpb_map_ctx *ufshpb_get_map_ctx(struct ufshpb_lu *hpb) > > +{ > > + struct ufshpb_map_ctx *mctx; > > + int i, j; > > + > > + mctx = mempool_alloc(ufshpb_drv.ufshpb_mctx_pool, GFP_KERNEL); > > + if (!mctx) > > + return NULL; > So you

RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-17 Thread Avri Altman
> + > +static struct ufshpb_map_ctx *ufshpb_get_map_ctx(struct ufshpb_lu *hpb) > +{ > + struct ufshpb_map_ctx *mctx; > + int i, j; > + > + mctx = mempool_alloc(ufshpb_drv.ufshpb_mctx_pool, GFP_KERNEL); > + if (!mctx) > + return NULL; So you use

Re: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-15 Thread Daejun Park
Hi Bean > > > On Mon, 2020-06-15 at 18:30 +0900, Daejun Park wrote: > > +static int ufshpb_execute_map_req(struct ufshpb_lu *hpb, > > + struct ufshpb_req *map_req) > > +{ > > + struct request_queue *q; > > + struct request *req; > > + struct

Re: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-15 Thread Bean Huo
Hi Daejun On Mon, 2020-06-15 at 18:30 +0900, Daejun Park wrote: > +static int ufshpb_execute_map_req(struct ufshpb_lu *hpb, > + struct ufshpb_req *map_req) > +{ > + struct request_queue *q; > + struct request *req; > + struct scsi_request *rq; >