Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-13 Thread Paolo Bonzini
On 14/10/19 07:50, Jianyong Wu (Arm Technology China) wrote: >> >> John (Stultz), does that sound good to you? The context is that Jianyong >> would like to add a hypercall that returns a (cycles, >> nanoseconds) pair to the guest. On x86 we're relying on the vclock_mode >> field that is already

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-13 Thread Jianyong Wu (Arm Technology China)
land ; Will Deacon > ; > >> Suzuki Poulose > >> Cc: linux-kernel@vger.kernel.org; k...@vger.kernel.org; Steve Capper > >> ; Kaly Xin (Arm Technology China) > >> ; Justin He (Arm Technology China) > >> ; nd ; linux-arm- > >> ker...@lists.infrad

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-09 Thread Paolo Bonzini
On 09/10/19 18:05, John Stultz wrote: > On Wed, Oct 9, 2019 at 2:13 AM Paolo Bonzini wrote: >> John (Stultz), does that sound good to you? The context is that >> Jianyong would like to add a hypercall that returns a (cycles, >> nanoseconds) pair to the guest. On x86 we're relying on the vclock_m

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-09 Thread John Stultz
On Wed, Oct 9, 2019 at 2:13 AM Paolo Bonzini wrote: > On 09/10/19 10:18, Jianyong Wu (Arm Technology China) wrote: > > > > We must ensure both of the host and guest using the same clocksource. > > get_device_system_crosststamp will check the clocksource of guest and we > > also need check > > the

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-09 Thread Paolo Bonzini
Xin (Arm Technology China) >> ; Justin He (Arm Technology China) >> ; nd ; linux-arm- >> ker...@lists.infradead.org >> Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm. >> >> On 09/10/19 07:21, Jianyong Wu (Arm Technology China) wrote: >>>

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-09 Thread Jianyong Wu (Arm Technology China)
opher...@intel.com; > richardcoch...@gmail.com; Mark Rutland ; Will > Deacon ; Suzuki Poulose > > Cc: linux-kernel@vger.kernel.org; k...@vger.kernel.org; Steve Capper > ; Kaly Xin (Arm Technology China) > ; Justin He (Arm Technology China) > ; nd ; linux-arm- > ker...@lists.infradead.

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-08 Thread Paolo Bonzini
On 09/10/19 07:21, Jianyong Wu (Arm Technology China) wrote: > As ptp_kvm clock has fixed to arm arch system counter in patch set > v4, we need check if the current clocksource is system counter when > return clock cycle in host, so a helper needed to return the current > clocksource. Could I add t

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-10-08 Thread Jianyong Wu (Arm Technology China)
opher...@intel.com; > richardcoch...@gmail.com; Mark Rutland ; Will > Deacon ; Suzuki Poulose > > Cc: linux-kernel@vger.kernel.org; k...@vger.kernel.org; Steve Capper > ; Kaly Xin (Arm Technology China) > ; Justin He (Arm Technology China) > ; nd ; linux-arm- > ker...@lists.infradead.

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-25 Thread Jianyong Wu (Arm Technology China)
adead.org > Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm. > > On 23/09/19 06:57, Jianyong Wu (Arm Technology China) wrote: > >> On 19/09/19 11:46, Jianyong Wu (Arm Technology China) wrote: > >>>> On 18/09/19 11:57, Jianyong Wu (Arm Technology

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-24 Thread Paolo Bonzini
On 23/09/19 06:57, Jianyong Wu (Arm Technology China) wrote: >> On 19/09/19 11:46, Jianyong Wu (Arm Technology China) wrote: On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: > Paolo Bonzini wrote: >> This is not Y2038-safe. Please use ktime_get_real_ts64 instead, >> an

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-22 Thread Jianyong Wu (Arm Technology China)
fradead.org > Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm. > > On 19/09/19 11:46, Jianyong Wu (Arm Technology China) wrote: > >> On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: > >>> Paolo Bonzini wrote: > >>>> T

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-22 Thread Jianyong Wu (Arm Technology China)
adead.org > Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm. > > On 19/09/19 13:39, Marc Zyngier wrote: > >> I don't think it's ugly but more important, using tk->tkr_mono.clock > >> is incorrect. See how the x86 code hardcodes &

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-19 Thread Paolo Bonzini
On 19/09/19 13:39, Marc Zyngier wrote: >> I don't think it's ugly but more important, using tk->tkr_mono.clock is >> incorrect. See how the x86 code hardcodes &kvm_clock, it's the same for >> ARM. > Not really. The guest kernel is free to use any clocksource it wishes. Understood, in fact it's th

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-19 Thread Marc Zyngier
On 19/09/2019 12:07, Paolo Bonzini wrote: > On 19/09/19 11:46, Jianyong Wu (Arm Technology China) wrote: >>> On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: Paolo Bonzini wrote: > This is not Y2038-safe. Please use ktime_get_real_ts64 instead, and > split the 64-bit secon

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-19 Thread Paolo Bonzini
On 19/09/19 11:46, Jianyong Wu (Arm Technology China) wrote: >> On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: >>> Paolo Bonzini wrote: This is not Y2038-safe. Please use ktime_get_real_ts64 instead, and split the 64-bit seconds value between val[0] and val[1]. > > Val[] sh

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-19 Thread Jianyong Wu (Arm Technology China)
adead.org > Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm. > > On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: > > Hi Paolo, > > > >> On 18/09/19 10:07, Jianyong Wu wrote: > >>> + case ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_I

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-18 Thread Paolo Bonzini
On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: > Hi Paolo, > >> On 18/09/19 10:07, Jianyong Wu wrote: >>> + case ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID: >>> + getnstimeofday(ts); >> >> This is not Y2038-safe. Please use ktime_get_real_ts64 instead, and split >> the >> 64-

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-18 Thread Jianyong Wu (Arm Technology China)
adead.org > Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm. > > On 18/09/19 10:07, Jianyong Wu wrote: > > + case ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID: > > + getnstimeofday(ts); > > This is not Y2038-safe. Please use ktime_get_real_ts64 i

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-18 Thread Paolo Bonzini
On 18/09/19 10:07, Jianyong Wu wrote: > + case ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID: > + getnstimeofday(ts); This is not Y2038-safe. Please use ktime_get_real_ts64 instead, and split the 64-bit seconds value between val[0] and val[1]. However, it seems to me that the new function