RE: [char-misc-next 2/8] mei: hbm: validate client index is not exceeding allocated array size

2013-11-07 Thread Winkler, Tomas
> > > > This somehow should guard buffer overflow allocated of size dev- > >me_clients_num > > In theory this can happen only if something go wrong in hardware > > initialization or there is some other security hole that can change > > client_num. > > What _kind_ of "security hole" could ever chan

Re: [char-misc-next 2/8] mei: hbm: validate client index is not exceeding allocated array size

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 07:31:06AM +, Winkler, Tomas wrote: > > > > > --- > > > drivers/misc/mei/hbm.c | 6 -- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c > > > index 9b3a0fb..0f5e8ca 100644 > > > --- a/dr

RE: [char-misc-next 2/8] mei: hbm: validate client index is not exceeding allocated array size

2013-10-30 Thread Winkler, Tomas
> > --- > > drivers/misc/mei/hbm.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c > > index 9b3a0fb..0f5e8ca 100644 > > --- a/drivers/misc/mei/hbm.c > > +++ b/drivers/misc/mei/hbm.c > > @@ -228,8 +228,6 @@ stat

Re: [char-misc-next 2/8] mei: hbm: validate client index is not exceeding allocated array size

2013-10-29 Thread Greg KH
On Mon, Oct 21, 2013 at 10:05:37PM +0300, Tomas Winkler wrote: > Signed-off-by: Tomas Winkler > --- > drivers/misc/mei/hbm.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c > index 9b3a0fb..0f5e8ca 100644 > --- a/driv