On Mon, 10 Feb 2014 16:54:16 -0500 Johannes Weiner wrote:
> How about this: we allow disabling the log message, but print the line
> of the disabling call so it's clear who dunnit. To make sure valuable
> info is not missing in bug reports, add counters for the two events in
> /proc/vmstat.
>
On Mon, 10 Feb 2014 16:54:16 -0500 Johannes Weiner han...@cmpxchg.org wrote:
How about this: we allow disabling the log message, but print the line
of the disabling call so it's clear who dunnit. To make sure valuable
info is not missing in bug reports, add counters for the two events in
On Mon, Feb 10, 2014 at 12:51:02PM -0800, Andrew Morton wrote:
> On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner wrote:
>
> > On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
> > > On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner
> > > wrote:
> > >
> > > > @@ -63,6 +64,9 @@
el@vger.kernel.org
> Subject: Re: [patch] drop_caches: add some documentation and info
> message
>
> On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner
> wrote:
>
> > On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
> > > On Fri, 7 Feb 2014 13:13:32 -0500 Joh
On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner wrote:
> On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
> > On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner
> > wrote:
> >
> > > @@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
> > > write,
> > >
On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner han...@cmpxchg.org wrote:
On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner han...@cmpxchg.org
wrote:
@@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
: [patch] drop_caches: add some documentation and info
message
On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner han...@cmpxchg.org
wrote:
On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner
han...@cmpxchg.org wrote
On Mon, Feb 10, 2014 at 12:51:02PM -0800, Andrew Morton wrote:
On Fri, 7 Feb 2014 16:26:01 -0500 Johannes Weiner han...@cmpxchg.org wrote:
On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner han...@cmpxchg.org
wrote:
On Fri, Feb 07, 2014 at 01:13:32PM -0500, Johannes Weiner wrote:
> On Fri, Feb 07, 2014 at 12:55:37PM -0500, Rik van Riel wrote:
> > On 02/07/2014 12:40 PM, Johannes Weiner wrote:
> >
> > >@@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
> > >write,
> > > if (ret)
> > >
On Fri, Feb 07, 2014 at 01:13:32PM -0500, Johannes Weiner wrote:
On Fri, Feb 07, 2014 at 12:55:37PM -0500, Rik van Riel wrote:
On 02/07/2014 12:40 PM, Johannes Weiner wrote:
@@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
write,
if (ret)
return
On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
> On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner wrote:
>
> > @@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
> > write,
> > iterate_supers(drop_pagecache_sb, NULL);
> > if
On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner wrote:
> @@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
> iterate_supers(drop_pagecache_sb, NULL);
> if (sysctl_drop_caches & 2)
> drop_slab();
> +
On 02/07/2014 01:13 PM, Johannes Weiner wrote:
Would it be better to print this after the operation
has completed?
It would make more sense grammatically :-) Either way is fine with me,
updated below to inform after the fact.
Well, in principle the operation could take an arbitrarily
long
On Fri, Feb 07, 2014 at 12:55:37PM -0500, Rik van Riel wrote:
> On 02/07/2014 12:40 PM, Johannes Weiner wrote:
>
> >@@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
> > if (ret)
> > return ret;
> > if (write) {
> >+
On 02/07/2014 12:40 PM, Johannes Weiner wrote:
@@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
if (ret)
return ret;
if (write) {
+ printk_ratelimited(KERN_INFO "%s (%d): dropped kernel caches:
%d\n",
+
On 02/07/2014 12:40 PM, Johannes Weiner wrote:
@@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
if (ret)
return ret;
if (write) {
+ printk_ratelimited(KERN_INFO %s (%d): dropped kernel caches:
%d\n,
+
On Fri, Feb 07, 2014 at 12:55:37PM -0500, Rik van Riel wrote:
On 02/07/2014 12:40 PM, Johannes Weiner wrote:
@@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
if (ret)
return ret;
if (write) {
+printk_ratelimited(KERN_INFO %s
On 02/07/2014 01:13 PM, Johannes Weiner wrote:
Would it be better to print this after the operation
has completed?
It would make more sense grammatically :-) Either way is fine with me,
updated below to inform after the fact.
Well, in principle the operation could take an arbitrarily
long
On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner han...@cmpxchg.org wrote:
@@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
iterate_supers(drop_pagecache_sb, NULL);
if (sysctl_drop_caches 2)
drop_slab();
On Fri, Feb 07, 2014 at 12:31:29PM -0800, Andrew Morton wrote:
On Fri, 7 Feb 2014 13:13:32 -0500 Johannes Weiner han...@cmpxchg.org wrote:
@@ -63,6 +64,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int
write,
iterate_supers(drop_pagecache_sb, NULL);
20 matches
Mail list logo
