RE: [rtc-linux] [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-22 Thread Tony Prisk
>> Converted the existing arch-vt8500 gpio to a platform_device. >> Added support for WM8505 and WM8650 GPIO controllers. >(...) >> + unsigned val; >I asked about the datatype for this "val", it sure isn't "unsigned". >I suspected the registers were only 8bit and so it should be u8. >But at

Re: [rtc-linux] [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-22 Thread Linus Walleij
On Tue, Aug 21, 2012 at 10:47 PM, Tony Prisk wrote: > Converted the existing arch-vt8500 gpio to a platform_device. > Added support for WM8505 and WM8650 GPIO controllers. (...) > + unsigned val; I asked about the datatype for this "val", it sure isn't "unsigned". I suspected the register